Skip to content

fix(bilibili): filter null subtitle content to prevent literal 'null' strings in video summaries #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −5
Open

fix(bilibili): filter null subtitle content to prevent literal 'null' strings in video summaries #964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/content-script/site-adapters/bilibili/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,10 @@ export default {
const subtitleData = await subtitleResponse.json()
const subtitles = subtitleData.body

let subtitleContent = ''
for (let i = 0; i < subtitles.length; i++) {
if (i === subtitles.length - 1) subtitleContent += subtitles[i].content
else subtitleContent += subtitles[i].content + ','
}
const subtitleContent = subtitles
.map((s) => s.content)
.filter((c) => c != null)
.join(',')
Comment on lines +54 to +57
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation assumes that subtitles is always an array and that each element s is a valid object. If the API returns an unexpected response (e.g., subtitleData.body is missing or contains null entries), this code will throw a TypeError. Adding a fallback for subtitles and using optional chaining for s.content would make this more robust.

Suggested change
const subtitleContent = subtitles
.map((s) => s.content)
.filter((c) => c != null)
.join(',')
const subtitleContent = (subtitles || [])
.map((s) => s?.content)
.filter((c) => c != null)
.join(',')


return await cropText(
`You are an expert video summarizer. Create a comprehensive summary of the following Bilibili video in markdown format, ` +
Expand Down