i18n(tr): improve Turkish translations and parity with EN#959
i18n(tr): improve Turkish translations and parity with EN#959cenktekin wants to merge 1 commit intoChatGPTBox-dev:masterfrom
Conversation
- Terminology fixes: Polish→Parlat, Precise→Kesin, Float Window→Yüzdür, UNAUTHORIZED→Yetkisiz - Add actionable guidance to context length error message - Update Claude login retry hint to match EN wording - Add missing EN key: Crop Text - Minor wording: Forever→Süresiz
Review Summary by QodoImprove Turkish translations and enhance EN parity
WalkthroughsDescription• Improve Turkish terminology consistency: Polish→Parlat, Precise→Kesin, Float Window→Yüzdür, UNAUTHORIZED→Yetkisiz • Add actionable guidance to context length error message with cleanup instructions • Update Claude login retry hint to match English wording with specific UI guidance • Add missing translation key for Crop Text feature • Minor wording refinement: Forever→Süresiz Diagramflowchart LR
A["Turkish Localization File"] -->|Terminology Updates| B["Polish→Parlat, Precise→Kesin"]
A -->|UI Text Improvements| C["Float Window→Yüzdür, UNAUTHORIZED→Yetkisiz"]
A -->|Error Message Enhancement| D["Add cleanup guidance to context length error"]
A -->|Login Hint Alignment| E["Match English retry button instruction"]
A -->|Missing Key Addition| F["Add Crop Text translation"]
A -->|Minor Refinements| G["Forever→Süresiz"]
File Changes1. src/_locales/tr/main.json
|
Code Review by Qodo
1. Token term inconsistent
|
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughTurkish localization strings updated across multiple UI labels including "Float the Window," error messages, and feature names. A new localization entry for "Crop Text" was added with guidance about managing input tokens relative to model limits. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates Turkish translations in src/_locales/tr/main.json to improve accuracy, including corrections for 'Polish' and 'Precise' and updated instructional text. Feedback suggests refactoring translation keys to be semantic rather than full English sentences to improve maintainability and avoid confusion when translations deviate from the literal key text.
| "Please login at https://bing.com first": "Lütfen önce https://bing.com adresinde oturum açın", | ||
| "Then open https://chatgpt.com/api/auth/session": "Ardından https://chatgpt.com/api/auth/session adresini açın", | ||
| "And refresh this page or type you question again": "Ve bu sayfayı yenileyin veya sorunuzu tekrar yazın", | ||
| "And refresh this page or type you question again": "Ve sağ üst köşedeki yeniden dene düğmesine tıklayın", |
There was a problem hiding this comment.
While the new Turkish translation correctly aligns with the English value ('And click the retry button in the top right corner'), the key And refresh this page or type you question again is now misleading. This creates a maintainability issue, as developers using this key would expect a different text. For better code clarity and long-term maintenance, it would be beneficial to refactor this to use a more semantic key (e.g., clickRetryButtonHint) across all locale files and the source code. This could be addressed in a follow-up task.
| "Type": "Tür", | ||
| "Mode": "Mod", | ||
| "Custom": "Özel", | ||
| "Crop Text to ensure the input tokens do not exceed the model's limit": "Girdi token sayısının model sınırını aşmaması için metni kırp", |
There was a problem hiding this comment.
Using the full English text as the translation key is a potential maintainability issue. If the source English text ever needs to be changed (even for a minor typo), the key itself must be changed, requiring updates across all locale files and in the code. A more robust and maintainable approach is to use shorter, semantic keys (e.g., cropTextDescription). While this PR follows the existing pattern in the file, it would be beneficial for the project's long-term health to consider a future refactoring of these keys.
There was a problem hiding this comment.
Pull request overview
This PR updates the Turkish locale (tr) strings to improve terminology, clarity, and keep parity with the English locale for UI labels and user-facing guidance.
Changes:
- Refines several Turkish translations (e.g., “Float the Window”, “UNAUTHORIZED”, “Polish”, “Precise”, “Forever”) for clearer terminology.
- Improves guidance text for the “Exceeded maximum context length” error to include an actionable next step.
- Adds the missing Turkish entry for the “Crop Text…” key to match EN parity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Please login at https://bing.com first": "Lütfen önce https://bing.com adresinde oturum açın", | ||
| "Then open https://chatgpt.com/api/auth/session": "Ardından https://chatgpt.com/api/auth/session adresini açın", | ||
| "And refresh this page or type you question again": "Ve bu sayfayı yenileyin veya sorunuzu tekrar yazın", | ||
| "And refresh this page or type you question again": "Ve sağ üst köşedeki yeniden dene düğmesine tıklayın", |
There was a problem hiding this comment.
Bu metinde düğme adı "yeniden dene" olarak geçiyor; ancak aynı dosyada "Retry" çevirisi "Tekrar Dene" (bkz. src/_locales/tr/main.json:93). UI’daki düğme etiketiyle birebir eşleşmesi için burada da aynı ifadeyi ve büyük harf kullanımını kullanın (örn. "Tekrar Dene" düğmesi).
Summary
Improve Turkish localization with better terminology and EN parity.
Changes
Scope
src/_locales/tr/main.jsononlyValidation
Notes
Clean restart from closed PR #898. Single commit, no conflicts with upstream master.
Summary by CodeRabbit