[ENG-10943] Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response#11719
Merged
cslzchen merged 2 commits intoCenterForOpenScience:feature/pbs-26-9from May 1, 2026
Conversation
Ostap-Zherebetskyi
changed the title
Ostap-Zherebetskyi
force-pushed
the
fix/subscription_detail_attr
branch
from
da7f4c4 to
08a09b3
Compare
cslzchen
requested changes
Apr 30, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Looks good overall. In addition to comments, can we update unit tests to make sure id and events are returned in API responses.
Ostap-Zherebetskyi
force-pushed
the
fix/subscription_detail_attr
branch
from
fb94d48 to
ad4d546
Compare
cslzchen
merged commit 0d4bd1d
into
CenterForOpenScience:feature/pbs-26-9
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response
Changes
Side Effects
QE Notes
CE Notes
Documentation