[ENG-10464] Critical issues in yarn.lock#11627
Open
antkryt wants to merge 5 commits intoCenterForOpenScience:feature/pbs-26-2from
Open
[ENG-10464] Critical issues in yarn.lock#11627antkryt wants to merge 5 commits intoCenterForOpenScience:feature/pbs-26-2from
antkryt wants to merge 5 commits intoCenterForOpenScience:feature/pbs-26-2from
Conversation
antkryt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
delete old and unused packages; remove some old UI
Changes
What was removed:
babel-core, babel-loader, markdown stack (@centerforopenscience/markdown-it-atrules, @centerforopenscience/markdown-it-imsize, @centerforopenscience/markdown-it-toc, @centerforopenscience/markdown-it-video, markdown-it, markdown-it-ins-del, markdown-it-sanitizer and all the transitive packages they brought), other unused packages
All the rest vulnerable packages are pulled in mostly by webpack@3, so to "fix" them it's required to migrate to webpack@5 or remove all (or most of the) web UI from the backend (or just upgrade vulnerable packages to the safe version, let me know if I need to do it for this ticket)
Admin package.json is untouched
Side Effects
QE Notes
CE Notes
Documentation