Skip to content

Update cert manager to 1.19.3#109

Merged
mfraezz merged 3 commits intoCenterForOpenScience:masterfrom
olehavramenko:feat/update-cert-manager
Mar 10, 2026
Merged

Update cert manager to 1.19.3#109
mfraezz merged 3 commits intoCenterForOpenScience:masterfrom
olehavramenko:feat/update-cert-manager

Conversation

@olehavramenko
Copy link
Collaborator

No description provided.

@olehavramenko olehavramenko marked this pull request as draft February 23, 2026 17:32
@olehavramenko olehavramenko marked this pull request as ready for review February 24, 2026 16:34
@mfraezz
Copy link
Member

mfraezz commented Mar 10, 2026

This looks a little different from what's at https://github.com/cert-manager/cert-manager/tree/master/deploy/charts/cert-manager, can you confirm where this chart was pulled from?

@olehavramenko
Copy link
Collaborator Author

olehavramenko commented Mar 10, 2026

This looks a little different from what's at https://github.com/cert-manager/cert-manager/tree/master/deploy/charts/cert-manager, can you confirm where this chart was pulled from?

Yes, I can confirm. That's the same chart with a small modification.

Removed unneeded files:

  • signkey_annotation.txt - removed
  • values.linter.exceptions - removed
  • Chart.template.yaml ---> Chart.yaml
  • README.template.md ---> README.md

CRDs:

Added crds folder. CRDS from that folder match exactly the same state of CRDs from the cert-manager/templates folder, which cert manager allows to apply with Helm, but in general it is not recommended to deploy CRDs with helm and it is considered not to be safe (cert manager provides workaround but still I would avoid this), so use kubectl apply -f crds/. Besides that you would not want to have your pipelines permissions to change CRDs.

@mfraezz mfraezz merged commit e6a5cd6 into CenterForOpenScience:master Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants