Migrate osf to use cos-common library#103
Open
olehavramenko wants to merge 2 commits intoCenterForOpenScience:masterfrom
Open
Migrate osf to use cos-common library#103olehavramenko wants to merge 2 commits intoCenterForOpenScience:masterfrom
olehavramenko wants to merge 2 commits intoCenterForOpenScience:masterfrom
Conversation
olehavramenko
force-pushed
the
feat/add-osf
branch
from
9579000 to
3437d33
Compare
mfraezz
requested changes
Mar 10, 2026
Member
mfraezz
left a comment
mfraezz
left a comment
There was a problem hiding this comment.
Generally looks good. Some opportunities for cleanup, one of which I'm uncertain about and should be ignored for now. Pass complete 
| readTimeout: 60 # http://nginx.org/en/docs/http/ngx_http_uwsgi_module.html#uwsgi_read_timeout | ||
| preprintRewrites: [] | ||
| # - rewrite ... | ||
| redirects: |
Member
There was a problem hiding this comment.
Deprecated, remove
(The redirects block, specifically. Angular handles this now)
mfraezz
reviewed
Mar 10, 2026
osf/values.yaml
Outdated
| # cpu: 100m | ||
| # memory: 256Mi | ||
| env: | ||
| - name: DJANGO_SETTINGS_MODULE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: please review and merge PR for library update first: #106