Skip to content

Updates to fix zoomcontrol Issue #1124#1200

Merged
ahouseholder merged 2 commits into
mainfrom
bug/Issue_1124
Jul 14, 2026
Merged

Updates to fix zoomcontrol Issue #1124#1200
ahouseholder merged 2 commits into
mainfrom
bug/Issue_1124

Conversation

@sei-vsarvepalli

Copy link
Copy Markdown
Contributor

Resolution to #1124 for the publish website to get the right update.

Copilot AI review requested due to automatic review settings July 9, 2026 20:07
@sei-vsarvepalli sei-vsarvepalli marked this pull request as draft July 9, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #1124 in the SSVC calculator UI by adjusting the stacking order of the zoom/scale slider so it can be interacted with (not covered by the graph layer) when using the Coordinator Triage model.

Changes:

  • Added a higher z-index to the #zoomcontrol container to ensure the vertical range input remains clickable/draggable above the rendered graph.
Comments suppressed due to low confidence (1)

docs/ssvc-calc/findex.html:152

  • alt is not a valid/accessibility-relevant attribute for <input type="range">. Use an accessible name (e.g., aria-label) so screen readers can announce the control consistently.
	     style="z-index:100">
	  <div class="d-none">&#128269;</div>
	  <input type="range" orient="vertical" alt="Zoom Graph"
		 max="100" min="0" value="100" title="Zoom Graph"
		 onchange="svgzoom(this)">

@sei-vsarvepalli

Copy link
Copy Markdown
Contributor Author

Also resolves the issue in #1198 - where there is a collision between div names if the strings are similar like "Supplier Cardinality" vs "Supplier Engagement"

@sei-vsarvepalli sei-vsarvepalli marked this pull request as ready for review July 9, 2026 20:47
@sei-renae

Copy link
Copy Markdown
Contributor

The scroll bar works now, but could there be a horizontal scroll as well?
image

@sei-vsarvepalli

Copy link
Copy Markdown
Contributor Author

The scroll bar works now, but could there be a horizontal scroll as well? image

The zoom works diagonally to do both really. It is not a horizontal only zoom per se.

const vbox = "0 0 "+String(parseInt(fw/zf)) + " " + String(parseInt(fh/zf))

@sei-renae

Copy link
Copy Markdown
Contributor
image

I mean this scroll bar - can we get a horizontal one of these?

@sei-vsarvepalli

Copy link
Copy Markdown
Contributor Author
image I mean this scroll bar - can we get a horizontal one of these?

not really. The SVG element growth is something div is unaware of as the display changes in the iframe. To really work out the display the whole iframe should be abandoned and the display integrated into the mkdocs directly. That is a lot more effort!

@ahouseholder ahouseholder merged commit 84819a7 into main Jul 14, 2026
5 checks passed
@ahouseholder ahouseholder deleted the bug/Issue_1124 branch July 14, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants