app: boards: add WeAct STM32F446 Core board configuration#182
Open
digiexchris wants to merge 1 commit intoCANnectivity:mainfrom
Open
app: boards: add WeAct STM32F446 Core board configuration#182digiexchris wants to merge 1 commit intoCANnectivity:mainfrom
digiexchris wants to merge 1 commit intoCANnectivity:mainfrom
Conversation
Member
|
Thanks! Looks good. Please add a signed-off-by line to the Git commit log. |
Add CANnectivity application overlay and Kconfig fragment for the WeAct Studio STM32F446 Core Board (weact_stm32f446_core). The overlay wires CAN1 (PB8 RX, PB9 TX, intended for an external SN65HVD230 transceiver) to a single CANnectivity channel and exposes TIM2 as the 1 MHz hardware timestamp counter (TIM2 input clock 84 MHz at the new SYSCLK, prescaler 83). The board's default main PLL configuration produces PLL_Q = 180 MHz, which is incompatible with USB OTG FS (requires exactly 48 MHz). The overlay reconfigures the main PLL (N=336, Q=7) so PLL_Q = 48 MHz while keeping a 168 MHz SYSCLK; this avoids enabling clk48/PLLSAI which would trip an upstream Zephyr build issue on STM32F446 (LL_RCC_PLLSAI_GetMainSource is not provided by the STM32F4 HAL). Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
digiexchris
force-pushed
the
add-weact-stm32f446-core-board
branch
from
99c7be5 to
2c39c8f
Compare
Author
done! I assumed signed off by you. |
Member
No, it should be signed off by you. Please see https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin I have an action for documenting the process for contributing to CANnectivity, apologies for not having this in place already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CANnectivity application overlay and Kconfig fragment for the WeAct Studio STM32F446 Core Board (weact_stm32f446_core).
The overlay wires CAN1 (PB8 RX, PB9 TX, intended for an external SN65HVD230 transceiver) to a single CANnectivity channel and exposes TIM2 as the 1 MHz hardware timestamp counter (TIM2 input clock 84 MHz at the new SYSCLK, prescaler 83).
The board's default main PLL configuration produces PLL_Q = 180 MHz, which is incompatible with USB OTG FS (requires exactly 48 MHz). The overlay reconfigures the main PLL (N=336, Q=7) so PLL_Q = 48 MHz while keeping a 168 MHz SYSCLK; this avoids enabling clk48/PLLSAI which would trip an upstream Zephyr build issue on STM32F446
(LL_RCC_PLLSAI_GetMainSource is not provided by the STM32F4 HAL).