Open
Conversation
Re-order the dependencies since all the npm tools keep re-ordering them and adjusting the whitespace.
Bumped react-scripts to 4.0.3 as well as any associated dependencies to have full TypeScript 4.x support. fixes Buuntu#177
TypeScript 4.x compile process complains about missing dependencies so add them in.
Author
|
includes the fix for #171 as well |
This failed to compile due to a mis-match of types with TypeScript 4.x. fixes Buuntu#168.
cardoe
force-pushed
the
fix-up-versions
branch
from
82b9b4a to
48dc388
Compare
Fix the lint 'import/prefer-default-export'
Fix the lint 'react/jsx-boolean-value'
Fix the lint 'no-shadow'.
Owner
|
Can we take out the extra changes and dependencies and just stick to the Typescript upgrade? I will approve with just that, I'd rather not add extra dependencies to the base project though. |
Author
|
Sure. The frontend won't compile without them. |
|
@cardoe Is this PR supposed to fix this error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project pulled in TypeScript 4.x but used other dependencies that were not compatible with TypeScript 4.x which resulted in failures out of the box that provided no context as to what was going wrong.