Open
Conversation
…y accessible shareable links for books, chapters, and pages without requiring authentication.
Member
|
Thanks for offering this PR @dev. To be honest though, when looking to implement this myself before I've thought through this style of approach but never really been happy with it, due to the large amount of duplication, re-implementation and the wide general surface-area/impact. Looking at this PR now, I still feel the same way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #288, #441, #687, #732, #979, #1215, #1279, #1551, #1802, #3479, #4611, #4712, #5105, #5650 :
This PR implements a "share links" feature that allows users to create publicly accessible shareable links for books, chapters, and pages without requiring authentication.
Features:
/share/{token})