WIP: WriteDREAM3D unit testing#1602
Draft
mmarineBlueQuartz wants to merge 7 commits into
Draft
Conversation
Collaborator
mmarineBlueQuartz
commented
Apr 22, 2026
mmarineBlueQuartz
commented
- Refactored into multiple functions for easier readability and added error value constant.
* Refactored into multiple functions for easier readability and added error value constant.
* Refactored into multiple functions for easier readability and added error value constant.
* Updating Metadata class for reading and writing DataObject metadata while preserving the data's type information. * Added abstract metadata value class for reading and writing metadata of a specific type with assignment and casting operators. * Adding collection of metadata types for creating the appropriate class object for a given json string
…r/WriteDREAM3DFilter
imikejackson
force-pushed
the
mtr/WriteDREAM3DFilter
branch
from
a5eb0cc to
aa394ae
Compare
* Added unit tests for bool, int, double, and string metadata types across round-trip .dream3dnx file IO. * Updated BaseMetadataValue API for reading and writing json. * Added MetaDataList for creating an expandable list of metadata value types from json. * Added a metadata value type for unknown value types to preserve the value even if the type is not known when reading data.
* Added bool, int, double, and string vector metadata types. * Added unit tests for new metadata types. * Added missing bool metadata testing
* Simplified MetaData API for setting and retrieving stored values. * Updated unit test to use the shortened setters and added additional checks against shortened getters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.