Prepare LabProtocol and LabProcess for Release#719
Open
HLWeil wants to merge 6 commits intoBioSchemas:masterfrom
Open
Prepare LabProtocol and LabProcess for Release#719HLWeil wants to merge 6 commits intoBioSchemas:masterfrom
HLWeil wants to merge 6 commits intoBioSchemas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal reference
Changes towards #715
Description
We substantially softened requirements of the
LabProtocolprofile and added a new propertyparameterto the type. We also added a profile forLabProcess.Motivation and context
We are making use of both the LabProcess and LabProtocol types extensively in the context of our ISA-RO-Crate-Profile and the ARC in RO-Crate. Here we identified the issue of too strict and extensive profiles, which are helpful in the context of a given community but can hinder interoperability between communities as the requirements vary. In our case, we softened the requirements of the LabProtocol profile to make it alignable with the Protocol class in ISA.
We would also like to advance the stable release of these types to make them more available (#715).
Have these been tested?
We have been using LabProcess and this less strict version of LabProtocol extensively in the context of our ISA-RO-Crate-Profile and the ARC.
What should reviewers focus on?
It would be great to get feedback on whether the changes are technically sound.
Types of changes
LabProtocol1.0_Drafttype (new version)parameterproperty (following the official guide)LabProtocol1.0_Draftprofile (new version)LabProcess0.1_Draftprofile (from scratch, following the official guide)LabProcess0.1_Draftexamples (new version)Future TO-DOs
LabProcessmissing from machine readable files #706)LabProtocolandLabProcessparameter,parameterValue, andexecutesProtocolas bioschemas properties