Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ function () {
\BEA\Theme\Framework\Framework::get_container()->boot_services();
}
);

require_once __DIR__ . '/inc/Helpers/Misc.php';
require_once __DIR__ . '/inc/Helpers/Svg.php';
require_once __DIR__ . '/inc/Helpers/Formatting/Escape.php';
require_once __DIR__ . '/inc/Helpers/Formatting/Image.php';
Expand Down
124 changes: 124 additions & 0 deletions inc/Helpers/Misc.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
<?php

namespace BEA\Theme\Framework\Helpers\Misc;

/**
* Get file infos
*
* @param int $file_id
*
* @return array $file_infos
*/
function get_file_infos( int $file_id ): array {
$file_href = wp_get_attachment_url( $file_id );
$file_infos = [
'href' => '',
'file_name' => '',
'path' => '',
'size' => '',
'ext' => '',
'caption' => '',
];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatched array keys between error and success paths

High Severity

The default/error return array uses keys path, size, ext, while the success return uses entirely different keys details, details_accessible, icon. Consumers of get_file_infos will encounter undefined index warnings depending on which path was taken, since the two array shapes are incompatible.

Additional Locations (1)
Fix in Cursor Fix in Web


if ( empty( $file_href ) ) {
return $file_infos;
}

$file_path = get_attached_file( $file_id );

if ( empty( $file_path ) ) {
return $file_infos;
}

$file_ext = pathinfo( $file_path, PATHINFO_EXTENSION );

if ( empty( $file_ext ) ) {
return $file_infos;
}

$file_size = (string) size_format( wp_filesize( $file_path ) );
$file_name = (string) ( get_the_title( $file_id ) ?? '' );

return [
'file_name' => $file_name,
'details' => get_file_detail( $file_name, $file_ext, $file_size ),
'details_accessible' => get_file_detail( $file_name, $file_ext, get_accessible_file_size_label( $file_size ) ),
'href' => $file_href,
'caption' => (string) wp_get_attachment_caption( $file_id ),
'icon' => get_file_icon( $file_ext ),
];
}

/**
* Get file details
*
* @param string $file_name
* @param string $file_ext
* @param string $file_size
*
* @return string $file_detail
*/
function get_file_detail( string $file_name, string $file_ext, string $file_size ): string {
$details = [];

if ( ! empty( $file_name ) ) {
$details[] = $file_name;
}

if ( ! empty( $file_ext ) ) {
$details[] = strtoupper( $file_ext );
}

if ( ! empty( $file_size ) ) {
$details[] = $file_size;
}

return implode( ' – ', $details );
}

/**
* Get accessible file size label
*
* @param string $file_size
*
* @return string
*/
function get_accessible_file_size_label( string $file_size ): string {
// Extract value and unit from file size (e.g., "7ko" → "7" + "ko").
preg_match( '/^([\d.,]+)\s*([a-zA-Z]+)$/', $file_size, $matches );
$value = $matches[1] ?? '';
$int_value = (int) $value; // Cast to int for _n() pluralization.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decimal file sizes get incorrect singular pluralization

Low Severity

Casting $value to int for _n() pluralization truncates decimal values, so a size like "1.5 MB" produces "1.5 megabyte" (singular) instead of "1.5 megabytes" (plural). Using ceil() or checking if the value differs from 1 would give correct plural forms for non-integer sizes.

Fix in Cursor Fix in Web

$unit = strtolower( $matches[2] ?? '' );

/* translators: file size units (byte, kilobyte, megabyte, etc.) */
$unit_label = match ( $unit ) {
'b', 'o' => _n( 'byte', 'bytes', $int_value, 'beapi-frontend-framework' ),
'kb', 'ko' => _n( 'kilobyte', 'kilobytes', $int_value, 'beapi-frontend-framework' ),
'mb', 'mo' => _n( 'megabyte', 'megabytes', $int_value, 'beapi-frontend-framework' ),
'gb', 'go' => _n( 'gigabyte', 'gigabytes', $int_value, 'beapi-frontend-framework' ),
'tb', 'to' => _n( 'terabyte', 'terabytes', $int_value, 'beapi-frontend-framework' ),
default => null,
};

if ( null === $unit_label ) {
return $file_size;
}

return $value . ' ' . $unit_label;
}

/**
* @param string $file_ext
*
* @return string
*/
function get_file_icon( string $file_ext ): string {

$file_icon = 'file';

if ( in_array( $file_ext, [ 'jpg', 'jpeg', 'png', 'gif', 'webp', 'svg', 'bmp', 'ico' ], true ) ) {
$file_icon = 'file-image';
}

return $file_icon;
}
1 change: 1 addition & 0 deletions src/img/icons/sprite/file-image.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/img/icons/sprite/file.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading