Skip to content

feat: 신설 전공/학부 추가#2159

Merged
Soundbar91 merged 3 commits intodevelopfrom
feat/2158-add-depth
Feb 27, 2026
Merged

feat: 신설 전공/학부 추가#2159
Soundbar91 merged 3 commits intodevelopfrom
feat/2158-add-depth

Conversation

@Soundbar91
Copy link
Collaborator

@Soundbar91 Soundbar91 commented Feb 27, 2026

🔍 개요


🚀 주요 변경 내용

신설 전공/학부 추가

  • 신설 전공/학부를 추가했습니다.
    • 반도체·디스플레이공학과
    • 미래융합학부
    • 공학융합자율전공
    • ICT융합자율전공
    • 사회융합자율전공

💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • New Features

    • Five new departments added for selection: Semiconductor Display Engineering; Future Convergence; Engineering Convergence (Autonomous Major); ICT Convergence (Autonomous Major); Social Convergence (Autonomous Major).
  • Style

    • Minor internal formatting cleanup in department retrieval logic — no behavioral changes.

@github-actions github-actions bot added the 공통 백엔드 공통으로 작업할 이슈입니다. label Feb 27, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60c0e5e and 14bd071.

📒 Files selected for processing (1)
  • src/main/java/in/koreatech/koin/domain/student/model/StudentDepartment.java

📝 Walkthrough

Walkthrough

Added five new department enum constants to both Dept and StudentDepartment, and a non-functional reformat of a majors-retrieval chain in DeptService (no behavior change).

Changes

Cohort / File(s) Summary
Department Enum Expansion
src/main/java/in/koreatech/koin/domain/dept/model/Dept.java
Inserted five new enum constants: SEMICONDUCTOR_DISPLAY_ENGINEERING, FUTURE_CONVERGENCE, ENGINEERING_CONVERGENCE_AUTONOMOUS_MAJOR, ICT_CONVERGENCE_AUTONOMOUS_MAJOR, SOCIAL_CONVERGENCE_AUTONOMOUS_MAJOR — each with Korean name, List.of("N/A"), and the shared curriculum URL.
StudentDepartment Enum Expansion
src/main/java/in/koreatech/koin/domain/student/model/StudentDepartment.java
Added the same five enum constants (Korean names) to the StudentDepartment enum. isValid behavior remains driven by enum values.
Formatting / Minor refactor
src/main/java/in/koreatech/koin/domain/dept/service/DeptService.java
Whitespace/indentation reformat of the getAllDepartmentsWithMajors major-retrieval chain; no semantic or behavioral change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped into the enum row,
Five new names in tidy tow,
Korean labels, links aligned,
A tiny change, but oh—refined! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: 신설 전공/학부 추가' clearly describes the main change: adding newly established majors/departments, which matches the PR's objective of reflecting new department/major changes in the codebase.
Linked Issues check ✅ Passed The PR successfully addresses issue #2158 by adding five new department/major enum constants to both Dept and StudentDepartment classes, meeting the requirement to reflect new academic program changes in the system.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to the objective of adding new departments/majors: enum constant additions in Dept.java and StudentDepartment.java, plus a minor formatting adjustment in DeptService.java that supports the main change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/2158-add-depth

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@dh2906 dh2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셔씁니다

@kih1015
Copy link
Contributor

kih1015 commented Feb 27, 2026

고생하셨습니다 굿굿

@Soundbar91 Soundbar91 self-assigned this Feb 27, 2026
@github-actions
Copy link

Unit Test Results

673 tests   670 ✔️  1m 23s ⏱️
165 suites      3 💤
165 files        0

Results for commit 14bd071.

@Soundbar91 Soundbar91 merged commit 7d67814 into develop Feb 27, 2026
7 checks passed
@Soundbar91 Soundbar91 deleted the feat/2158-add-depth branch February 27, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

공통 백엔드 공통으로 작업할 이슈입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[유저] 학부/학과 변경사항 대응

3 participants