fix issue 210: deploy-to-aca.ps1: StateStore connection string trunca…#211
Open
sebastianstephan wants to merge 2 commits intoAzureCosmosDB:mainfrom
Open
fix issue 210: deploy-to-aca.ps1: StateStore connection string trunca…#211sebastianstephan wants to merge 2 commits intoAzureCosmosDB:mainfrom
sebastianstephan wants to merge 2 commits intoAzureCosmosDB:mainfrom
Conversation
…ted to first character on macOS/Linux
Collaborator
|
The fix doesn't work on Windows. Looks like we need to have separate code sections for Windows and Non-Windows. On windows after applying the fix Step 4 never completes. |
…d the script with separate handling of windows and non-windows platforms
Contributor
Author
|
@sandeepsnairms I fixed it again and made the script distinguishe between windows systems and non windows systems. For Windows I stick with the original solution from you. For non-windows I picked the alternative approach. The new script for ACA deployment was tested on MacOS and Windows and now works properly on both. Feel free to merge :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Replace PtrToStringAuto with PtrToStringBSTR, which correctly reads the BSTR length prefix and decodes the full UTF-16 string on all platforms.
Free the BSTR pointer via ZeroFreeBSTR in a finally block.
Remove escaped quotes from the stateStoreConnectionString Bicep parameter.
Testing
Verified on macOS with PowerShell Core — full connection string is now correctly passed to the Bicep deployment.