Skip to content

Bump compileSdkVersion → 36, buildToolsVersion → 36.0.0, browserVersion → 1.9.0, Fixes AB#3561424#410

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-build-version-variables
Draft

Bump compileSdkVersion → 36, buildToolsVersion → 36.0.0, browserVersion → 1.9.0, Fixes AB#3561424#410
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-build-version-variables

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 31, 2026

Upgrades centralized build version variables to support the AuthTabIntent API (requires AndroidX Browser ≥ 1.9.0 / Chrome 137+) and align SDK tooling with API 36.

gradle/versions.gradle

  • compileSdkVersion: 35 → 36
  • buildToolsVersion: 35.0.036.0.0
  • browserVersion: 1.7.01.9.0
  • targetSdkVersion and minSdkVersion left unchanged at 35 and 24 respectively

onNewIntent signature compatibility

compileSdkVersion 36 changes ComponentActivity.onNewIntent to accept Intent? (nullable). All Activity overrides in this repo were audited — none were found requiring updates. SwitchBrowserActivity.kt in the common module (separate repo) was confirmed to already carry the correct nullable signature:

override fun onNewIntent(intent: Intent?) {
    super.onNewIntent(intent)
    setIntent(intent)
    // ...
}
Original prompt

Fixes AB#3561424

Objective

Upgrade the centralized build version variables in versions.gradle to enable the AuthTabIntent API and fix all onNewIntent signature breaks caused by the compileSdkVersion 36 upgrade.

Follow .github/copilot-instructions.md strictly.

Technical Requirements

  1. In gradle/versions.gradle, update:

    • browserVersion from 1.7.0 to 1.9.0
    • compileSdkVersion from 35 to 36
    • buildToolsVersion from 35.0.0 to 36.0.0
    • Do NOT change minSdkVersion (keep at 24) or targetSdkVersion (keep at 35)
  2. Search the entire repo for Activity subclasses overriding onNewIntent(intent: Intent) (non-nullable Kotlin parameter) and update to onNewIntent(intent: Intent?):

    • Add null-safety handling in the method body
    • Preserve super.onNewIntent(intent) and setIntent(intent) calls
    • Known affected: SwitchBrowserActivity.kt in common module
  3. Verify compilation across all modules after the changes.

Files to Modify

  • gradle/versions.gradle - Version bumps (browserVersion, compileSdkVersion, buildToolsVersion)
  • All Activity subclass files with onNewIntent(intent: Intent) override - Update parameter to nullable Intent?

Acceptance Criteria

  • browserVersion is 1.9.0, compileSdkVersion is 36, buildToolsVersion is 36.0.0
  • targetSdkVersion remains 35, minSdkVersion remains 24
  • All onNewIntent(intent: Intent) overrides updated to onNewIntent(intent: Intent?)
  • Null-safety handled in all updated methods
  • Clean compilation across all modules

@github-actions
Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3561424 to an Azure Boards work item.

…wserVersion to 1.9.0

Agent-Logs-Url: https://github.com/AzureAD/android-complete/sessions/b7566c86-2b19-481a-af29-1f7b07942f11

Co-authored-by: p3dr0rv <76129899+p3dr0rv@users.noreply.github.com>
Copilot AI changed the title [WIP] Fixes AB#3561424 - Upgrade build version variables in versions.gradle Bump compileSdkVersion → 36, buildToolsVersion → 36.0.0, browserVersion → 1.9.0 Mar 31, 2026
Copilot AI requested a review from p3dr0rv March 31, 2026 20:27
@github-actions github-actions bot changed the title Bump compileSdkVersion → 36, buildToolsVersion → 36.0.0, browserVersion → 1.9.0 Bump compileSdkVersion → 36, buildToolsVersion → 36.0.0, browserVersion → 1.9.0, Fixes AB#3561424 Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants