Skip to content

Suppress false-positive CodeQL warning in RemoteOrchestrationServiceClient #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnatoliB wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −0
Open

Suppress false-positive CodeQL warning in RemoteOrchestrationServiceClient #1347

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab93cc
Add CodeQL suppressions for serialization security warnings in PutJso…
AnatoliB May 1, 2026
6c6ab0b
Fix suppression syntax
AnatoliB May 1, 2026
52430cb
Move suppression comment to the correct line
AnatoliB May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DurableTask.AzureServiceFabric/Remote/RemoteOrchestrationServiceClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ private async Task PutJsonAsync(string instanceId, string fragment, object @obje
{
var mediaFormatter = new JsonMediaTypeFormatter()
{
// CodeQL [SM02211] False positive: serialization (write) path only; no untrusted JSON is deserialized here.
SerializerSettings = new JsonSerializerSettings { TypeNameHandling = TypeNameHandling.All }
};
Comment on lines +308 to 310
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn’t appear to use a suppression syntax that GitHub CodeQL recognizes (e.g., lgtm[cs/<query-id>] / codeql[cs/<query-id>] style), so it may not actually suppress the alert that prompted this PR. If the goal is suppression (not just justification), use the repository’s supported CodeQL inline suppression mechanism or adjust the CodeQL configuration/queries to ignore this specific finding, and reference the query id that maps to SM02211.

Copilot uses AI. Check for mistakes.

Expand Down
Loading