Suppress SM05220 in src/DurableTask.AzureStorage/MessageManager.cs#1342
Open
Suppress SM05220 in src/DurableTask.AzureStorage/MessageManager.cs#1342
src/DurableTask.AzureStorage/MessageManager.cs#1342Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR suppresses a security analyzer finding (SM05220) in MessageManager by explicitly documenting and justifying the use of Json.NET TypeNameHandling.Objects (with a serialization binder) when round-tripping polymorphic DurableTask history payloads through customer-owned Azure Storage.
Changes:
- Added
SuppressMessageattributes to silence .NET security analyzer warnings (CA2326/CA2327) for theMessageManagerconstructor. - Added an inline rationale comment describing why
TypeNameHandling.Objectsis required in this component and how the trust boundary is considered.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolving https://msazure.visualstudio.com/Antares/_workitems/edit/37181656 Co-authored-by: Copilot <copilot@github.com>
AnatoliB
force-pushed
the
anatolib/codeql-fix-37181656
branch
from
d9164d4 to
89a7a10
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving
https://msazure.visualstudio.com/Antares/_workitems/edit/37181656