-
Notifications
You must be signed in to change notification settings - Fork 317
Inherit default values for EntityCacheOption.Enabled and EntityCacheOption.Level from RuntimeCacheOptions #3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronburtle
wants to merge
34
commits into
main
Choose a base branch
from
dev/aaronburtle/InheritEntityCacheEnabldedAndLevelFromRuntimeSetting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+391
−40
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
340ef73
take default for entity cache enabled and level from runtime cache se…
aaronburtle 44c8335
include test for new behavior
aaronburtle eea3044
addressing comments
aaronburtle 5649f2b
merge conflicts
aaronburtle 07a2bd9
revert accidental change
aaronburtle 6039a1e
addressing comments
aaronburtle d808b30
cleanup
aaronburtle 2fdb41b
return null for calarity when no cache
aaronburtle 08047f1
remove duplicated function and refactor around
aaronburtle 9eabaac
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
aaronburtle 3baf002
remove redundant row in test
aaronburtle bc9cc4b
fix casing for level
aaronburtle 88bc81e
dont write back non user provided
aaronburtle fbe4245
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
aaronburtle 1ac1899
fixing tests
aaronburtle 48fc491
Merge branch 'dev/aaronburtle/InheritEntityCacheEnabldedAndLevelFromR…
aaronburtle bd54ac6
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
aaronburtle 2a80f14
fix null write back behaviors
aaronburtle f46687d
fix bool name
aaronburtle 6e219c3
typo in snapshot files
aaronburtle f455f14
access time, L1L2 default, test added
aaronburtle d8399f1
resolve merge conflicts
aaronburtle 99fc1ee
fix mocked class
aaronburtle 45e2759
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
aaronburtle bebdbe8
try to fix nuget job
aaronburtle d727dbc
pipeline fix ported int
aaronburtle cc0a2b8
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
aaronburtle 893268c
use IsCachingEnabled
aaronburtle f031b8b
align default level to infferred/L1
aaronburtle 92e127b
Merge branch 'dev/aaronburtle/InheritEntityCacheEnabldedAndLevelFromR…
aaronburtle cbffd20
update comment
aaronburtle 3a3fe09
fix snapshots
aaronburtle b1fcde4
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
Aniruddh25 62dd15d
Merge branch 'main' into dev/aaronburtle/InheritEntityCacheEnabldedAn…
aaronburtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ | |
| Cache: { | ||
| Enabled: true, | ||
| TtlSeconds: 1, | ||
| Level: L1L2, | ||
| Level: L1, | ||
| UserProvidedLevelOptions: false | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,7 +44,7 @@ | |
| Cache: { | ||
| Enabled: true, | ||
| TtlSeconds: 1, | ||
| Level: L1L2, | ||
| Level: L1, | ||
| UserProvidedLevelOptions: false | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.Runtime.Serialization; | ||
|
|
||
| namespace Azure.DataApiBuilder.Config.ObjectModel; | ||
|
|
||
| public enum EntityCacheLevel | ||
| { | ||
| [EnumMember(Value = "L1")] | ||
| L1, | ||
| [EnumMember(Value = "L1L2")] | ||
| L1L2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.