Cosmos: test enhancements#47501
Open
simorenoh wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Cosmos full-text policy tests to reduce pipeline flakiness by removing assertions that depend on specific service error message text, keeping only HTTP status code checks.
Changes:
- Removed several
re.search(...)assertions onCosmosHttpResponseError.http_error_messagefor full-text indexing policy failure cases (sync + async). - Kept the tests validating failure via
status_code == 400(and existingpytest.fail(...)guards where present).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/tests/test_full_text_policy.py | Removes error-message regex assertions for several 400 failure cases in full-text indexing policy tests. |
| sdk/cosmos/azure-cosmos/tests/test_full_text_policy_async.py | Mirrors the sync test changes by removing error-message regex assertions for the async variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service keeps updating and refining error messages, which means our pipelines will see errors every time they do. So long as status code stays the same, we should be ok with not asserting anything inside the text.
also adds api.md file that is now required by Core