[AutoPR azure-confidentialledger]-generated-from-SDK Generation - Python-6435812#47499
Open
azure-sdk wants to merge 1 commit into
Open
[AutoPR azure-confidentialledger]-generated-from-SDK Generation - Python-6435812#47499azure-sdk wants to merge 1 commit into
azure-sdk wants to merge 1 commit into
Conversation
…tialLedger/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '8a3262d0e5c399e19b4e489368643a0e5b7f16e3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6435812 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
There was a problem hiding this comment.
Pull request overview
This is an auto-generated regeneration of azure-confidentialledger from the Confidential Ledger data-plane TypeSpec configuration, updating the pinned spec commit and moving the package to a 2.0.0 release with refreshed generated client/models/operations and supporting utilities.
Changes:
- Update the TypeSpec/spec source pointers (
tsp-location.yaml,_metadata.json) and bump the library version to2.0.0. - Regenerate core client/models/operations code and utilities (notably
_utils/model_base.py,_utils/serialization.py, new_validation.py, and various model/operation updates). - Remove several previously shipped handwritten/custom surfaces (receipt verification module, redirect caching policy, patch-based convenience clients/pollers), and adjust/format some tests and packaging configuration.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/confidentialledger/azure-confidentialledger/tsp-location.yaml | Updates TypeSpec source directory + spec commit reference (but additionalDirectories now empty/ambiguous). |
| sdk/confidentialledger/azure-confidentialledger/tests/test_redirect_caching_policy.py | Minor formatting tweak in assertions (tests still reference deleted redirect policy module). |
| sdk/confidentialledger/azure-confidentialledger/tests/test_client_configuration.py | Minor formatting; still asserts disable_redirect_cleanup=True behavior. |
| sdk/confidentialledger/azure-confidentialledger/sdk_packaging.toml | Removed; packaging metadata moved into pyproject.toml. |
| sdk/confidentialledger/azure-confidentialledger/pyproject.toml | Reformat + dependency/version metadata updates; adds [packaging] section. |
| sdk/confidentialledger/azure-confidentialledger/CHANGELOG.md | Adds a 2.0.0 entry, but currently contains placeholder/internal instruction text. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/py.typed | Deleted (receipt subpackage removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/_utils.py | Deleted (receipt subpackage removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/_receipt_verification.py | Deleted (receipt subpackage removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/_receipt_models.py | Deleted (receipt subpackage removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/_claims_models.py | Deleted (receipt subpackage removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/_claims_digest_computation.py | Deleted (receipt subpackage removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/receipt/init.py | Deleted (receipt subpackage removed / public exports removed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/models/_patch.py | Updates typing for __all__ stub. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/models/_models.py | Regenerated models; docstring wrapping fixes; role-related model adjustments and other changes. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/models/_enums.py | Regenerated enums with docstring punctuation/formatting changes. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/models/init.py | Updates exported model names (removes Roles, adds UserDefinedRole(s)). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_patch.py | Replaced prior async convenience wrapper with an empty customization stub. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_operations/_patch.py | Replaced prior async poller helpers with an empty customization stub. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_operations/_operations.py | Regenerated async operations; adds list_tags and version validation hooks; introduces decompress handling for stream paths; renames some operations to *_stable. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_configuration.py | Updates default API version and docstring wording (docstring currently inconsistent with implementation). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_client.py | Regenerated async client; changes Self import strategy and pipeline policy composition (redirect/sensitive-header behavior changed). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_version.py | Bumps version to 2.0.0. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_validation.py | New helper decorator for API version validation of methods/params. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_utils/serialization.py | Updates Self import strategy; removes eval usage; adds deserializer fast-path for simple header/scalar cases. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_utils/model_base.py | Large regeneration/optimization changes to model serialization/deserialization and XML handling. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_redirect_caching_policy.py | Deleted; removes custom redirect caching + strict redirect target validation implementation. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_patch.py | Replaced prior sync convenience wrapper with an empty customization stub. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_operations/_patch.py | Replaced prior sync poller helpers with an empty customization stub. |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_configuration.py | Updates default API version and docstring wording (docstring currently inconsistent with implementation). |
| sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_client.py | Regenerated sync client; changes Self import strategy and pipeline policy composition (redirect/sensitive-header behavior changed). |
| sdk/confidentialledger/azure-confidentialledger/apiview-properties.json | Updates ApiView mapping entries (adds list_tags and new role models; renames some operations) and adds CrossLanguageVersion. |
| sdk/confidentialledger/azure-confidentialledger/_metadata.json | Updates API version metadata and adds apiVersions, commit, emitter/tooling metadata. |
Comments suppressed due to low confidence (4)
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_patch.py:22
azure.confidentialledger._patchno longer defines/export any of the previously public convenience types (e.g.,ConfidentialLedgerCertificateCredential, and the higher-levelConfidentialLedgerClientwrapper that acceptedendpoint,credential, andledger_certificate_path). The current generated client surface only acceptsledger_endpointand has no credential parameter, which will break existing usage (README + tests) and makes authenticated calls impossible without manual policy wiring.
__all__: list[str] = [] # Add all objects you want publicly available to users at this package level
def patch_sdk():
"""Do not remove from this file.
`patch_sdk` is a last resort escape hatch that allows you to do customizations
you can't accomplish using the techniques described in
https://aka.ms/azsdk/python/dpcodegen/python/customize
"""
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_patch.py:22
azure.confidentialledger.aio._patchis now empty, removing the async public convenience client/wrapper surface. As a result the async client currently has nocredential-based constructor and no TLS certificate convenience behavior, which is a breaking API change and will break existing samples/tests.
__all__: list[str] = [] # Add all objects you want publicly available to users at this package level
def patch_sdk():
"""Do not remove from this file.
`patch_sdk` is a last resort escape hatch that allows you to do customizations
you can't accomplish using the techniques described in
https://aka.ms/azsdk/python/dpcodegen/python/customize
"""
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_operations/_patch.py:22
- This operations patch file is now empty, which removes the previously provided
begin_*poller helpers (e.g.,begin_get_ledger_entry,begin_get_receipt,begin_wait_for_commit). Those helpers are used by existing tests and are part of the public convenience surface for non-LRO polling. If the generated operations no longer include them, they need to remain implemented somewhere for backwards compatibility (or be called out as a breaking change in the 2.0.0 changelog + docs).
__all__: list[str] = [] # Add all objects you want publicly available to users at this package level
def patch_sdk():
"""Do not remove from this file.
`patch_sdk` is a last resort escape hatch that allows you to do customizations
you can't accomplish using the techniques described in
https://aka.ms/azsdk/python/dpcodegen/python/customize
"""
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_operations/_patch.py:22
- This async operations patch file is now empty, removing the previously provided async
begin_*poller helpers. Existing tests callawait client.begin_get_ledger_entry(...)etc; without these helpers on the async client surface, this is a breaking change that should either be restored or explicitly documented in the 2.0.0 changelog (and reflected in samples/tests).
__all__: list[str] = [] # Add all objects you want publicly available to users at this package level
def patch_sdk():
"""Do not remove from this file.
`patch_sdk` is a last resort escape hatch that allows you to do customizations
you can't accomplish using the techniques described in
https://aka.ms/azsdk/python/dpcodegen/python/customize
"""
| commit: 8a3262d0e5c399e19b4e489368643a0e5b7f16e3 | ||
| repo: Azure/azure-rest-api-specs | ||
| additionalDirectories: [] | ||
| additionalDirectories: |
Comment on lines
15
to
18
| classifiers = [ | ||
| "Development Status :: 4 - Beta", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3 :: Only", |
Comment on lines
+77
to
+84
| [packaging] | ||
| package_name = "azure-confidentialledger" | ||
| package_pprint_name = "Azure Confidential Ledger" | ||
| package_doc_id = "" | ||
| is_stable = false | ||
| is_arm = false | ||
| need_msrestazure = false | ||
| auto_update = false |
Comment on lines
+3
to
+6
| ## 2.0.0 (2026-06-15) | ||
|
|
||
| skip changelog generation for data-plane package and please add changelog manually. | ||
|
|
Comment on lines
56
to
61
| self._config.authentication_policy, | ||
| self._config.custom_hook_policy, | ||
| self._config.logging_policy, | ||
| policies.DistributedTracingPolicy(**kwargs), | ||
| # Redirect cleanup is disabled to preserve authentication and ledger-specific headers | ||
| # on service-managed redirects. Confidential Ledger redirects are expected to stay within | ||
| # the same trusted ledger endpoint, so forwarding these sensitive headers is required | ||
| # for correct authentication behavior. | ||
| policies.SensitiveHeaderCleanupPolicy( | ||
| disable_redirect_cleanup=True, **kwargs | ||
| ) if self._config.redirect_policy else None, | ||
| policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None, | ||
| self._config.http_logging_policy, |
Comment on lines
55
to
62
| self._config.retry_policy, | ||
| self._config.authentication_policy, | ||
| self._config.custom_hook_policy, | ||
| self._config.logging_policy, | ||
| policies.DistributedTracingPolicy(**kwargs), | ||
| policies.SensitiveHeaderCleanupPolicy( | ||
| disable_redirect_cleanup=True, **kwargs | ||
| ) if self._config.redirect_policy else None, | ||
| policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None, | ||
| self._config.http_logging_policy, | ||
| ] |
Comment on lines
22
to
29
| :param ledger_endpoint: The Confidential Ledger URL, for example | ||
| `https://contoso.confidentialledger.azure.com <https://contoso.confidentialledger.azure.com>`_. | ||
| Required. | ||
| :type ledger_endpoint: str | ||
| :keyword api_version: The API version to use for this operation. Default value is | ||
| "2024-12-09-preview". Note that overriding this default value may result in unsupported | ||
| behavior. | ||
| :keyword api_version: The API version to use for this operation. Known values are "2026-02-23" | ||
| and None. Default value is None. If not set, the operation's default API version will be used. | ||
| Note that overriding this default value may result in unsupported behavior. | ||
| :paramtype api_version: str |
Comment on lines
22
to
29
| :param ledger_endpoint: The Confidential Ledger URL, for example | ||
| `https://contoso.confidentialledger.azure.com <https://contoso.confidentialledger.azure.com>`_. | ||
| Required. | ||
| :type ledger_endpoint: str | ||
| :keyword api_version: The API version to use for this operation. Default value is | ||
| "2024-12-09-preview". Note that overriding this default value may result in unsupported | ||
| behavior. | ||
| :keyword api_version: The API version to use for this operation. Known values are "2026-02-23" | ||
| and None. Default value is None. If not set, the operation's default API version will be used. | ||
| Note that overriding this default value may result in unsupported behavior. | ||
| :paramtype api_version: str |
Comment on lines
51
to
55
| self._config.user_agent_policy, | ||
| self._config.proxy_policy, | ||
| policies.ContentDecodePolicy(**kwargs), | ||
| kwargs.get("redirect_policy") or RedirectCachingPolicy(**kwargs), | ||
| self._config.redirect_policy, | ||
| self._config.retry_policy, |
Comment on lines
50
to
56
| self._config.headers_policy, | ||
| self._config.user_agent_policy, | ||
| self._config.proxy_policy, | ||
| policies.ContentDecodePolicy(**kwargs), | ||
| kwargs.get("redirect_policy") or AsyncRedirectCachingPolicy(**kwargs), | ||
| self._config.redirect_policy, | ||
| self._config.retry_policy, | ||
| self._config.authentication_policy, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/confidentialledger/data-plane/ConfidentialLedger/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '8a3262d0e5c399e19b4e489368643a0e5b7f16e3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6435812 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan information is not available. Create a release plan and link SDK pull request to the release plan. Refer aka.ms/azsdk/releaseplan-dashboard for more info.
Release Plan Details