[Storage] Enabled black for azure-storage-file-datalake package#47098
Open
weirongw23-msft wants to merge 4 commits into
Open
[Storage] Enabled black for azure-storage-file-datalake package#47098weirongw23-msft wants to merge 4 commits into
black for azure-storage-file-datalake package#47098weirongw23-msft wants to merge 4 commits into
Conversation
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request appears to be a repo-wide formatting pass for azure-storage-file-datalake to align code with black (and related formatting conventions) across tests, samples, and the package implementation.
Changes:
- Reformats tests, samples, and library modules to
black-style formatting (quotes, wrapping, trailing commas, spacing). - Normalizes some long statements/argument lists into
black-preferred multi-line layouts. - Minor whitespace/blank-line normalization across the package.
Reviewed changes
Copilot reviewed 80 out of 80 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-datalake/tests/test_large_file.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/test_large_file_async.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/test_helpers.py | Formatting updates; also contains an invalid super(...) call in MockHttpClientResponse.__init__. |
| sdk/storage/azure-storage-file-datalake/tests/test_helpers_async.py | Formatting updates; also contains an invalid super(...) call in MockAioHttpClientResponse.__init__. |
| sdk/storage/azure-storage-file-datalake/tests/test_datalake_service_client.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/test_cpk.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/test_cpk_async.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/settings/testcase.py | Formatting updates; retains redundant duplicate LOGGING_FORMAT assignment. |
| sdk/storage/azure-storage-file-datalake/tests/settings/settings_fake.py | Formatting-only updates (quotes). |
| sdk/storage/azure-storage-file-datalake/tests/perfstress_tests/upload.py | Formatting-only updates (wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/perfstress_tests/upload_from_file.py | Formatting-only updates (quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/perfstress_tests/append.py | Formatting-only updates (wrapping). |
| sdk/storage/azure-storage-file-datalake/tests/perfstress_tests/_test_base.py | Formatting-only updates (wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/setup.py | Formatting-only updates (quotes/wrapping/trailing commas). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_upload_download.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_upload_download_async.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_service.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_service_async.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_query.py | Formatting-only updates (large bytes literal rewrapped). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_instantiate_client.py | Formatting-only updates (quotes/blank lines). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_instantiate_client_async.py | Formatting-only updates (quotes/blank lines). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_file_system.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_file_system_async.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_directory.py | Formatting-only updates (wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_directory_async.py | Formatting-only updates (wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_access_control.py | Formatting-only updates (quotes/spacing/wrapping). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_access_control_recursive.py | Formatting-only updates (wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_access_control_recursive_async.py | Formatting-only updates (wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/samples/datalake_samples_access_control_async.py | Formatting-only updates (wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/conftest.py | Formatting-only updates (blank line). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_upload_helper.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_path_client_async.py | Formatting-only updates (imports/wrapping/quotes/trailing commas). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_models.py | Formatting-only updates (super call wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_list_paths_helper.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_download_async.py | Formatting-only updates (imports/quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_service_client_async.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_lease_async.pyi | Formatting-only updates (typing import formatting). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_lease_async.py | Formatting-only updates (imports/quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_file_client_async.pyi | Formatting-only updates (Literal quoting). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_file_client_async.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_directory_client_async.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/init.py | Formatting-only updates (__all__ quoting). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_upload_helper.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/uploads.py | Formatting-only updates (whitespace). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/response_handlers.py | Formatting-only updates (string concatenation layout). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/request_handlers.py | Formatting-only updates (whitespace). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/constants.py | Formatting-only updates (whitespace). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/base_client.py | Formatting-only updates (spacing/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/base_client_async.py | Formatting-only updates (quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared_access_signature.py | Formatting-only updates (imports/quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_serialize.py | Formatting-only updates (quotes/wrapping/trailing commas). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_quick_query_helper.py | Formatting-only updates (imports). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_path_client.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_path_client_helpers.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_list_paths_helper.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_file_system_client_helpers.py | Formatting-only updates (quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_download.py | Formatting-only updates (imports/quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_deserialize.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_service_client.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_service_client_helpers.py | Formatting-only updates (quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_lease.pyi | Formatting-only updates (typing import formatting). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_lease.py | Formatting-only updates (imports/quotes/wrapping). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_file_client.pyi | Formatting-only updates (Literal quoting). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_file_client.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_file_client_helpers.py | Formatting-only updates (typing import formatting / quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_directory_client.py | Formatting-only updates (imports/wrapping/quotes). |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/init.py | Formatting updates; retains duplicate DataLakeFileQueryError entry in __all__. |
| sdk/storage/azure-storage-file-datalake/azure/storage/init.py | Formatting-only updates (quotes). |
| sdk/storage/azure-storage-file-datalake/azure/init.py | Formatting-only updates (quotes). |
Comments suppressed due to low confidence (1)
sdk/storage/azure-storage-file-datalake/tests/test_helpers_async.py:66
super(MockAioHttpClientResponse).__init__()is not a valid super call in an instance method and will raise aTypeErrorwhenMockAioHttpClientResponseis instantiated. Usesuper().__init__(...)with the requiredaiohttp.ClientResponseconstructor args, or avoid calling the base initializer if you are intentionally creating a lightweight stand-in response object.
Member
Author
|
CI will still fail due to dependency check with blob version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.