Skip to content

update for fix schema validation #47075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Gnanasundaramsampath-sys wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update for fix schema validation #47075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions sdk/ml/azure-ai-ml/azure/ai/ml/_schema/schedule/schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from marshmallow import fields

from azure.ai.ml._schema.core.fields import ArmStr, NestedField, UnionField
from azure.ai.ml._schema.core.fields import ArmStr, NestedField, TypeSensitiveUnionField, UnionField
from azure.ai.ml._schema.core.resource import ResourceSchema
from azure.ai.ml._schema.job import CreationContextSchema
from azure.ai.ml._schema.schedule.create_job import (
Expand Down Expand Up @@ -33,12 +33,14 @@ class ScheduleSchema(ResourceSchema):


class JobScheduleSchema(ScheduleSchema):
create_job = UnionField(
[
create_job = TypeSensitiveUnionField(
{
"pipeline": [NestedField(PipelineCreateJobSchema)],
"command": [NestedField(CommandCreateJobSchema)],
"spark": [NestedField(SparkCreateJobSchema)],
},
plain_union_fields=[
ArmStr(azureml_type=AzureMLResourceType.JOB),
CreateJobFileRefField,
NestedField(PipelineCreateJobSchema),
NestedField(CommandCreateJobSchema),
NestedField(SparkCreateJobSchema),
]
],
)
11 changes: 11 additions & 0 deletions sdk/ml/azure-ai-ml/tests/schedule/unittests/test_schedule_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,14 @@ def test_load_invalid_schedule_missing_type(self):
with pytest.raises(ValidationError) as e:
load_schedule(test_path)
assert "'type' must be specified when scheduling a remote job with updates." in e.value.messages[0]

def test_load_invalid_schedule_pipeline_file_not_found_error_simplified(self):
test_path = "./tests/test_configs/schedule/invalid/hello_cron_schedule_with_pipeline_file_not_found.yml"
with pytest.raises(ValidationError) as e:
load_schedule(test_path)

error_message = str(e.value.messages)
assert "No such file or directory" in error_message
assert "Not supporting non file for create_job" not in error_message
assert "Value 'pipeline' passed is not in set ['command']" not in error_message
assert "Value 'pipeline' passed is not in set ['spark']" not in error_message
8 changes: 8 additions & 0 deletions .../tests/test_configs/schedule/invalid/hello_cron_schedule_with_pipeline_file_not_found.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
$schema: https://azuremlschemas.azureedge.net/latest/schedule.schema.json
name: weekly_retrain_2022_cron_pipeline_file_not_found
trigger:
type: cron
expression: "15 10 * * 1"
create_job:
type: pipeline
job: ../pipeline.yml
Loading