[Storage FileDatalake] Migrating to TypeSpec#45883
Draft
l0lawrence wants to merge 63 commits into
Draft
Conversation
Member
Author
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into filedatalake
…into filedatalake
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolved conflicts in azure-storage-file-datalake tests/samples by keeping the PR's reformatted versions (Azure#46809 was pure pylint reformatting, already covered by the branch's own reformat). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…into filedatalake
Member
Author
|
need to fix versioning* |
l0lawrence
commented
Jun 11, 2026
| from typing_extensions import Self | ||
|
|
||
| from azure.core import CaseInsensitiveEnumMeta | ||
| from azure.storage.filedatalake._generated.models._patch import _BackCompatMixin |
Member
Author
There was a problem hiding this comment.
and some might have had xml_map
kashifkhan
reviewed
Jun 11, 2026
| ) | ||
| path_client = AzureDataLakeStorageRESTAPI( | ||
| url, version=self._api_version, filesystem=self.file_system_name, path=deleted_path_name, pipeline=pipeline | ||
| url, filesystem=self.file_system_name, path=deleted_path_name, pipeline=pipeline |
Member
There was a problem hiding this comment.
just checking, no need to pass in version here?
kashifkhan
reviewed
Jun 11, 2026
| # -------------------------------------------------------------------------- | ||
|
|
||
| VERSION = "12.26.0b1" | ||
| VERSION = "1.0.0b1" |
Member
There was a problem hiding this comment.
this might need correcting :)
l0lawrence
commented
Jun 15, 2026
| # to ResourceModifiedError based on x-ms-error-code. | ||
| if isinstance( | ||
| storage_error, | ||
| (PartialBatchErrorException, ClientAuthenticationError, ResourceNotFoundError, ResourceExistsError), |
Member
Author
There was a problem hiding this comment.
Generated code how it handles generated error mapping is the reasoning for this diff**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-recorded tests related to append_data content-type issue
***we patched convenience layer to fix resourcenotexists condition not met issue
need to regen, fix models patch and fix formatting