[Storage Blob] Migrating to TypeSpec#45133
Open
l0lawrence wants to merge 224 commits into
Open
Conversation
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
l0lawrence
commented
Apr 22, 2026
| @@ -56,6 +56,10 @@ def upload_data_chunks( | |||
| if parallel and "modified_access_conditions" in kwargs: | |||
| # Access conditions do not work with parallelism | |||
| kwargs["modified_access_conditions"] = None | |||
| if parallel: | |||
Member
Author
There was a problem hiding this comment.
if-mathjc if-none-match headers were converted to etag/match-condition params in new generated code
l0lawrence
added a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Apr 27, 2026
Updates request_handlers.py, response_handlers.py, uploads.py, and uploads_async.py under azure-storage-file-datalake/_shared to match the latest changes from azure-storage-blob's storageblob3 branch (PR Azure#45133). Docstrings preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts: # sdk/storage/azure-storage-blob/samples/blob_samples_authentication.py # sdk/storage/azure-storage-blob/samples/blob_samples_authentication_async.py # sdk/storage/azure-storage-blob/samples/blob_samples_batch_delete_blobs.py # sdk/storage/azure-storage-blob/samples/blob_samples_client_side_encryption.py # sdk/storage/azure-storage-blob/samples/blob_samples_common.py # sdk/storage/azure-storage-blob/samples/blob_samples_common_async.py # sdk/storage/azure-storage-blob/samples/blob_samples_container_access_policy.py # sdk/storage/azure-storage-blob/samples/blob_samples_container_access_policy_async.py # sdk/storage/azure-storage-blob/samples/blob_samples_containers.py # sdk/storage/azure-storage-blob/samples/blob_samples_containers_async.py # sdk/storage/azure-storage-blob/samples/blob_samples_query.py # sdk/storage/azure-storage-blob/samples/blob_samples_service.py # sdk/storage/azure-storage-blob/samples/blob_samples_service_async.py # sdk/storage/azure-storage-blob/samples/blob_samples_walk_blob_hierarchy.py # sdk/storage/azure-storage-blob/tests/avro/test_avro.py # sdk/storage/azure-storage-blob/tests/avro/test_avro_async.py # sdk/storage/azure-storage-blob/tests/encryption_test_helper.py # sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/_test_base_legacy.py # sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/list_blobs.py # sdk/storage/azure-storage-blob/tests/perfstress_tests/_test_base.py # sdk/storage/azure-storage-blob/tests/perfstress_tests/download_basic.py # sdk/storage/azure-storage-blob/tests/perfstress_tests/list_blobs.py # sdk/storage/azure-storage-blob/tests/settings/testcase.py # sdk/storage/azure-storage-blob/tests/test_append_blob.py # sdk/storage/azure-storage-blob/tests/test_append_blob_async.py # sdk/storage/azure-storage-blob/tests/test_blob_access_conditions.py # sdk/storage/azure-storage-blob/tests/test_blob_access_conditions_async.py # sdk/storage/azure-storage-blob/tests/test_blob_client.py # sdk/storage/azure-storage-blob/tests/test_blob_client_async.py # sdk/storage/azure-storage-blob/tests/test_blob_encryption.py # sdk/storage/azure-storage-blob/tests/test_blob_encryption_async.py # sdk/storage/azure-storage-blob/tests/test_blob_encryption_v2.py # sdk/storage/azure-storage-blob/tests/test_blob_encryption_v2_async.py # sdk/storage/azure-storage-blob/tests/test_blob_service_properties.py # sdk/storage/azure-storage-blob/tests/test_blob_service_properties_async.py # sdk/storage/azure-storage-blob/tests/test_blob_tags.py # sdk/storage/azure-storage-blob/tests/test_blob_tags_async.py # sdk/storage/azure-storage-blob/tests/test_block_blob.py # sdk/storage/azure-storage-blob/tests/test_block_blob_async.py # sdk/storage/azure-storage-blob/tests/test_block_blob_sync_copy.py # sdk/storage/azure-storage-blob/tests/test_block_blob_sync_copy_async.py # sdk/storage/azure-storage-blob/tests/test_common_blob.py # sdk/storage/azure-storage-blob/tests/test_common_blob_async.py # sdk/storage/azure-storage-blob/tests/test_container.py # sdk/storage/azure-storage-blob/tests/test_container_async.py # sdk/storage/azure-storage-blob/tests/test_cpk_n.py # sdk/storage/azure-storage-blob/tests/test_cpk_n_async.py # sdk/storage/azure-storage-blob/tests/test_get_blob.py # sdk/storage/azure-storage-blob/tests/test_get_blob_async.py # sdk/storage/azure-storage-blob/tests/test_helpers.py # sdk/storage/azure-storage-blob/tests/test_large_block_blob.py # sdk/storage/azure-storage-blob/tests/test_logging.py # sdk/storage/azure-storage-blob/tests/test_logging_async.py # sdk/storage/azure-storage-blob/tests/test_page_blob.py # sdk/storage/azure-storage-blob/tests/test_page_blob_async.py # sdk/storage/azure-storage-blob/tests/test_quick_query.py # sdk/storage/azure-storage-blob/tests/test_quick_query_async.py # sdk/storage/azure-storage-blob/tests/test_retry.py # sdk/storage/azure-storage-blob/tests/test_retry_async.py # sdk/storage/azure-storage-blob/tests/test_transports.py
…into storageblob3
… and tsp datalake
…rClient The prior fix for the AccessPolicy leak in get_container_access_policy referenced AccessPolicy at runtime but only imported it under TYPE_CHECKING, causing NameError when the sync code path was hit. Also apply the same items_property/_from_generated wrap to the async get_container_access_policy, which was still returning the generated AccessPolicy directly. Verified against azure-cli storage tests (recorded mode): fixes test_storage_blob_container_operations, test_storage_container_acl_scenarios, and test_storage_container_access_policy_scenario. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommended actions (copilot given)
and confirm with the core team.