Skip to content

azure-cosmos-spark 4.44.2 release at 2026-03-05#48268

Merged
FabianMeiswinkel merged 6 commits intomainfrom
users/fabianm/PinnedCosmosArmInSpark
Mar 5, 2026
Merged

azure-cosmos-spark 4.44.2 release at 2026-03-05#48268
FabianMeiswinkel merged 6 commits intomainfrom
users/fabianm/PinnedCosmosArmInSpark

Conversation

@FabianMeiswinkel
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel commented Mar 5, 2026

  • Pinned resourcemanager-cosmos to 2.53.4 in Spark Connector to unblock usage in Non-Public clouds
  • Changed Storage account for new ephemeral test tenant

Copilot AI review requested due to automatic review settings March 5, 2026 09:26
@FabianMeiswinkel FabianMeiswinkel requested review from a team and kirankumarkolli as code owners March 5, 2026 09:26
@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - spark

@github-actions github-actions bot added the Cosmos label Mar 5, 2026
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR downgrades azure-resourcemanager-cosmos from 2.54.1 to 2.53.4 in the Spark Connector parent POM to unblock usage in Non-Public clouds (e.g., Azure Government, Azure China). Version 2.54.0 of azure-resourcemanager-cosmos updated the API version to 2025-10-15, which is likely not yet available in Non-Public cloud environments. The version is pinned using a Maven property to intentionally bypass the repository's automated x-version-update mechanism.

Changes:

  • Introduced a Maven property pinned-resourcemanager-cosmos.version set to 2.53.4 and used it for the azure-resourcemanager-cosmos dependency version, replacing the x-version-update-tracked version of 2.54.1.

You can also share your feedback on Copilot code review. Take the survey.

@FabianMeiswinkel FabianMeiswinkel requested a review from Copilot March 5, 2026 09:36
@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - spark

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


You can also share your feedback on Copilot code review. Take the survey.

@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - spark

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FabianMeiswinkel FabianMeiswinkel changed the title Pinned resourcemanager-cosmos to 2.53.4 in Spark Connector to unblock usage in Non-Public clouds azure-cosmos-spark 4.44.2 release at 2026-03-05 Mar 5, 2026
@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - spark

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member

PR Deep Review — azure-cosmos-spark 4.44.2

Overall Assessment: Approve with minor fixes

This hotfix correctly pins azure-resourcemanager-cosmos to 2.53.4 to restore Spark connector functionality in non-public clouds. The root cause was PR #47860 — an automated bulk merge-back that bumped RM Cosmos from 2.54.0 → 2.54.1, pulling in an API version not yet deployed to non-public clouds. Release 4.44.1 shipped with this broken dependency; this hotfix addresses it.

The approach — using a Maven property to opt out of {x-version-update} automation — is a novel pattern (no precedent found in this repo), but it is the correct tactical solution for this situation. The property is self-documenting and the x-version-update marker was properly removed from the dependency line.

Mechanical completeness: All 5 connector variants, the sample POM, the Fabric auth POM, version_client.txt, all CHANGELOGs, all READMEs, quick-start.md, and spark.yml are consistently updated. No missing files. ✅

Top findings:

  • 🔴 Two typos in all 5 user-facing CHANGELOG entries ("reseourcemanager", "publci")
  • 🟡 No tracking mechanism to eventually unpin the dependency
  • 🟡 CHANGELOG categorization should be "Bugs Fixed" rather than "Other Changes"

Additional notes:

  • If squash-merging, ensure the final commit message fixes the typo from commit f5d6f1b ("resourcemanaer" → "resourcemanager")
  • The Scala semicolon removal and storage account rotation are clean, well-isolated changes
  • version_client.txt GA column correctly stays at 4.44.1 per Azure SDK convention

See inline comments for details.


⚠️ AI-generated review — may be incorrect. Agree? → resolve the conversation. Disagree? → reply with your reasoning.

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Deep Review — 6 inline comments posted. See summary comment above for overall assessment.

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@FabianMeiswinkel
Copy link
Member Author

/azp run java - cosmos - spark

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@FabianMeiswinkel FabianMeiswinkel merged commit a5d012d into main Mar 5, 2026
42 checks passed
@FabianMeiswinkel FabianMeiswinkel deleted the users/fabianm/PinnedCosmosArmInSpark branch March 5, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants