Skip to content

mgmt, cosmos, add customization that would be needed by typespec source#48155

Merged
weidongxu-microsoft merged 2 commits intoAzure:mainfrom
weidongxu-microsoft:mgmt_cosmos
Feb 28, 2026
Merged

mgmt, cosmos, add customization that would be needed by typespec source#48155
weidongxu-microsoft merged 2 commits intoAzure:mainfrom
weidongxu-microsoft:mgmt_cosmos

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Feb 27, 2026

done by skill Azure/autorest.java#3297

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Feb 27, 2026
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review February 27, 2026 10:13
Copilot AI review requested due to automatic review settings February 27, 2026 10:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds customization code for the Azure Cosmos DB management plane library in preparation for TypeSpec-based code generation. The customization ensures backward compatibility by maintaining the current inheritance structure when the code is regenerated from TypeSpec.

Changes:

  • Adds customization to change the base class of DatabaseAccountGetResultsInner from ProxyResource (TypeSpec default) to Resource (current implementation)
  • Follows the established pattern used in other management plane libraries (KeyVault, ServiceBus) for TypeSpec migration

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/cosmos/azure-resourcemanager-cosmos/customization/src/main/java/CosmosCustomization.java Implements base class customization to maintain backward compatibility during TypeSpec migration
sdk/cosmos/azure-resourcemanager-cosmos/customization/pom.xml Maven configuration for customization module using azure-code-customization-parent

@weidongxu-microsoft
Copy link
Member Author

/azp run java - cosmos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member Author

/azp run java - pullrequest

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@weidongxu-microsoft
Copy link
Member Author

/check-enforcer override

@weidongxu-microsoft weidongxu-microsoft merged commit 820bca1 into Azure:main Feb 28, 2026
3 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_cosmos branch February 28, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants