Sync eng/common directory with azure-sdk-tools for PR 14196#48146
Open
Sync eng/common directory with azure-sdk-tools for PR 14196#48146
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs eng/common PowerShell tooling with the corresponding changes in azure-sdk-tools PR 14196, primarily updating test resource subscription selection and improving cleanup behavior for resource groups that can get “stuck” due to Storage Sync resources.
Changes:
- Add cleanup helper to delete Storage Sync Services (and dependent sync groups/endpoints) prior to resource group deletion.
- Update default “well-known” subscription selection to prefer Azure SDK Test Resources - TME and suppress Az subscription selection warnings.
- Add explicit Az module requirements needed by the enhanced cleanup flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/Resource-Helpers.ps1 | Adds Remove-StorageSyncServices helper to remove Storage Sync resources that block RG deletion. |
| eng/common/TestResources/Update-TestResources.ps1 | Updates default subscription selection and warning suppression (but includes a regression in subscription restore logic). |
| eng/common/TestResources/Remove-TestResources.ps1 | Adds Az module requirements, updates default subscription selection, and invokes Storage Sync cleanup before RG deletion. |
benbp
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow