Load balance bug

[mrm9084]

Description

• Fixes a bug where the configuration and feature flag refresh used different clients. Caused an issue if load balancing was enabled in a store that used feature flags could not refresh with feature flags.
• Fixes an issue where load balancing relplicas were removed from the active list after use.
• Removes the unused currentReplica variable. From the previous change to activeClient.

Note: A second PR will be created to randomize the active replica list for load balancing.

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[Copilot]

Pull request overview

This PR addresses load-balancing behavior in Spring Cloud Azure App Configuration refresh flows to ensure configuration and feature-flag refresh use consistent client selection and to avoid dropping replicas from the active rotation.

Changes:

• Adjusts ConnectionManager#getNextActiveClient to rotate clients for round-robin load balancing instead of removing them from the active list.
• Updates refresh logic to select clients consistently between configuration refresh checks and feature-flag refresh checks.
• Removes now-unused “current replica” tracking and updates tests and changelog accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManager.java	Changes load-balancing selection to round-robin rotation; removes unused replica tracking.
sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationReplicaClientFactory.java	Removes API used for tracking “current” replica client.
sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationRefreshUtil.java	Aligns refresh retry/client selection behavior for configuration vs feature-flag checks.
sdk/spring/spring-cloud-azure-appconfiguration-config/src/test/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManagerTest.java	Updates expectations for new round-robin behavior.
sdk/spring/spring-cloud-azure-appconfiguration-config/src/test/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationRefreshUtilTest.java	Removes obsolete verification tied to removed “current client” API.
sdk/spring/spring-cloud-azure-appconfiguration-config/CHANGELOG.md	Adds a bug-fix entry describing the load-balancing/feature-flag refresh fix.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/ConnectionManager.java:102

• In getNextActiveClient, the local variable name clients shadows the instance field clients, which makes the control flow harder to follow and easy to misread (especially since this method also mutates activeClients). Rename the local variable to something like availableClients (or similar) to avoid shadowing and improve readability.

        if (useLastActive) {
            List<AppConfigurationReplicaClient> clients = getAvailableClients();
            for (AppConfigurationReplicaClient client: clients) {
                if (client.getEndpoint().equals(lastActiveClient)) {
                    return client;

[Copilot]

The tests no longer assert the key behavior this PR is fixing: configuration refresh should select a client with useLastActive=false, and feature-flag refresh should reuse the same client with useLastActive=true (especially in the single-client load-balancing case where activeClients is emptied by the config check). Please strengthen/add a regression test that verifies getNextActiveClient(endpoint, false) is used for configuration and getNextActiveClient(endpoint, true) for feature flags, and that both checks operate on the same client in the single-store scenario.