[ARO] az aro: Clarify that --tags is for each individual resource#33521
Open
komidore64 wants to merge 1 commit into
Open
[ARO] az aro: Clarify that --tags is for each individual resource#33521komidore64 wants to merge 1 commit into
az aro: Clarify that --tags is for each individual resource#33521komidore64 wants to merge 1 commit into
Conversation
komidore64
requested review from
Pan-Qi,
VeryEarly,
jsntcy and
necusjz
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves the aro command module argument documentation by adding explicit help text for the --tags parameter.
Changes:
- Adds a custom help string for the
tagsargument by combining a new sentence with the existingtags_typehelp text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| c.argument('tags', | ||
| tags_type) | ||
| tags_type, | ||
| help='Tag a individual resource. ' + tags_type.settings['help']) |
| c.argument('tags', | ||
| tags_type) | ||
| tags_type, | ||
| help='Tag a individual resource. ' + tags_type.settings['help']) |
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @komidore64! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
komidore64
force-pushed
the
aro-27517-tags-help
branch
from
826865f to
9d6198b
Compare
Collaborator
|
ARO |
Co-authored-by: Caden Marchese <cmarches@redhat.com> Ref: https://redhat.atlassian.net/browse/ARO-27517
komidore64
force-pushed
the
aro-27517-tags-help
branch
from
9d6198b to
c0fea66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Resolve some confusion around that resources a tag attaches to.
Testing Guide
Read help for
--tags.History Notes
Nothing to add.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.