{Core} Validate endpoint origin to prevent access token leakage#33511
Draft
necusjz wants to merge 3 commits into
Draft
{Core} Validate endpoint origin to prevent access token leakage#33511necusjz wants to merge 3 commits into
necusjz wants to merge 3 commits into
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
added
Auto-Assign
Collaborator
|
Core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Problem:
Azure CLI used str.startswith() to check whether a URL targets a trusted Azure endpoint before attaching an access token. A lookalike host like
https://management.azure.com.attackercould matchhttps://management.azure.comvia prefix matching, causing the token to be sent to an attacker-controlled origin.Fix:
Added is_same_origin(url, endpoint) in
util.pythat does exact origin comparison (scheme + host + port), handling default ports and userinfo (user@host) tricks. Applied it to:Tests:
Added coverage for is_same_origin, the az rest token-leak scenario, and the AAZ next_link validation, including lookalike-host and userinfo spoofing cases.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.