[Resource] Suppress bicep install skip output when check_version is disabled and stabilize data-boundary live tests#33467
[Resource] Suppress bicep install skip output when check_version is disabled and stabilize data-boundary live tests#33467Copilot wants to merge 4 commits into
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Live test results —
|
|
Resource |
a0x1ab
left a comment
There was a problem hiding this comment.
Agent Assist Review — PR #33467
CI checks: ✅ All 94 checks passed (94 passed, 0 failed, 0 pending)
Live-test (resource module): ❌ Failed
- Run: https://github.com/Azure/issue-sentinel/actions/runs/26570408386
- The live-test workflow completed with
failure. Please investigate the test run logs.
@copilot Please review the live-test failure above and address any issues before this PR is ready for merge.
Posted by agent-assist (autonomous bug-fix pipeline).
Investigated the live-test failure and fixed it in commit |
Live test results —
|
a0x1ab
left a comment
There was a problem hiding this comment.
Review: Live Test Failed ❌
CI checks: ✅ All 94 checks passed.
Live test (azdev test resource --live): ❌ FAIL
The live test run (workflow run) failed with the following error in test_dataBoundary.py:
JMESPathCheckAssertionError: Query 'properties.dataBoundary' doesn't yield expected value 'EU',
instead the actual value is 'Global'.
The test is asserting properties.dataBoundary == 'EU' but the live environment returned 'Global'. This PR's title mentions "stabilize data-boundary live test" but the test is still failing in the live environment.
Action needed: @copilot Please investigate why the data-boundary live test is still asserting EU instead of handling Global. The test at src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_dataBoundary.py:12 needs to either:
- Accept any valid
dataBoundaryvalue (not hardcodeEU), or - Conditionally skip if the subscription's data boundary is not
EU.
Posted by agent-assist (autonomous bug-fix pipeline).
Addressed in |
Live test results —
|
a0x1ab
left a comment
There was a problem hiding this comment.
Agent Review — PR #33467
CI Checks
All 108/108 checks passed. ✅
Live Test (issue-sentinel)
Result: ❌ 1 failed, 13 passed
Workflow run: https://github.com/Azure/issue-sentinel/actions/runs/27258804641
Failure details
The failing test is in the resource module — a resource lock test:
azure.core.exceptions.HttpResponseError: (AuthorizationFailed) The client '***' with object id
'047fedc7-622b-4164-9085-e0d704999024' does not have authorization to perform action
'Microsoft.Authorization/locks/write' over scope
'.../resourceGroups/cli_test_cannotdelete_resource_group_lock.../providers/Microsoft.Authorization/locks/...'
or the scope is invalid.
The test cli_test_cannotdelete_resource_group_lock failed because the live-test runner's service principal lacks Microsoft.Authorization/locks/write permission. This appears to be a test environment permissions issue, not a regression introduced by this PR (which targets bicep install output suppression and data-boundary test stabilization).
@copilot — please confirm whether the resource lock test failure is pre-existing / environment-related, or if the PR inadvertently affects the resource locks test path. If it's a known permissions gap in the live-test runner, the test may need to be skipped in live mode or the runner RBAC role needs updating.
Posted by agent-assist (autonomous bug-fix pipeline).
Confirmed this failure is environment/RBAC-related and not from this PR’s code path. In run |
Related command
az bicep publish --file <file> --target <target>az data-boundary show --scope <scope> --default defaultaz data-boundary show-tenant --default defaultDescription
This PR keeps
az bicep publishoutput clean when Bicep version checks are disabled, and stabilizes resource live tests for data-boundary responses that vary by tenant/subscription environment.What changed
check_versionis disabled.test_dataBoundary.pylive assertions to handle valid environment-dependent values:properties.dataBoundary: acceptEUorGlobal(tenant and scope tests).properties.provisioningState: acceptCreatedorSucceeded.Effect
Testing Guide
azdev test resource --live --seriesMicrosoft.Authorization/locks/write), not from this PR’s modified code path.History Notes
[Resource]
az bicep publish --file <file> --target <target>: Suppress Bicep install-skip output when version checks are disabled.[Resource]
az data-boundary show --scope <scope> --default default: Stabilize live test assertions for valid environment-dependent dataBoundary/provisioningState values.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.