[SQL] az sql server/db: Add support for versionless TDE keys#32764
[SQL] az sql server/db: Add support for versionless TDE keys#32764
az sql server/db: Add support for versionless TDE keys#32764Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This pull request adds support for versionless Transparent Data Encryption (TDE) Azure Key Vault (AKV) keys for SQL server and database-level Customer Managed Keys (CMK). This enhancement allows users to specify AKV keys without a version identifier, enabling automatic key rotation.
Changes:
- Updates azure-mgmt-sql dependency from 4.0.0b22 to 4.0.0b23 across all platform-specific requirements files
- Modifies
_get_server_key_name_from_urifunction to parse and handle versionless key URIs - Adds comprehensive test coverage for versionless key operations (create, show, set, delete)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.py3.windows.txt | Updates azure-mgmt-sql dependency to 4.0.0b23 for Windows |
| requirements.py3.Linux.txt | Updates azure-mgmt-sql dependency to 4.0.0b23 for Linux |
| requirements.py3.Darwin.txt | Updates azure-mgmt-sql dependency to 4.0.0b23 for macOS |
| custom.py | Modifies URI parsing logic and regex to support versionless AKV keys, adds mdep.azure.net domain |
| test_sql_commands.py | Adds comprehensive test coverage for versionless key CRUD operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
|
Please fix CI issues |
az sql server/db: Add support for versionless TDE keys
Related command
Description
This PR adds the support for versionless TDE AKV keys for server and database level CMK
Testing Guide
History Notes
az sql server key create/show: Support versionless TDE keysaz sql server tde-key set/show: Support versionless TDE keysaz sql db create/show/update: Support versionless TDE keysThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.