FEAT: Adding audio scoring #1337
Merged
+1,466
−486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbolor21
changed the title
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
rlundeen2
reviewed
Jan 30, 2026
Contributor
|
I think it would be great reading through this @jbolor21 https://junkangworld.com/blog/inheritance-vs-composition-5-key-rules-for-clean-code-2025 or if you have more time, you can explore |
rlundeen2
reviewed
Feb 5, 2026
rlundeen2
reviewed
Feb 5, 2026
rlundeen2
reviewed
Feb 5, 2026
rlundeen2
reviewed
Feb 5, 2026
Contributor
bashirpartovi
left a comment
bashirpartovi
left a comment
There was a problem hiding this comment.
Looks great, just some minor comments
bashirpartovi
approved these changes
Feb 9, 2026
Contributor
bashirpartovi
left a comment
bashirpartovi
left a comment
There was a problem hiding this comment.
Awesome job @jbolor21 , just a few minor nits, feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding scorers to evaluate audio files by using AzureTTS to transcribe an audio file. I have also added this scorer to our video files so we can now score the audio in generated videos as well. This works by extracting the audio from the generated video and then using this new base audio scorer.
Tests and Documentation
Added examples in our notebooks for a demo and added unit tests