-
Notifications
You must be signed in to change notification settings - Fork 664
FEAT Breaking: Dataset Initializer and Scenario Datasets #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rlundeen2
merged 23 commits into
Azure:main
from
rlundeen2:users/rlundeen/12_5_dataset_initializer
Dec 9, 2025
Merged
FEAT Breaking: Dataset Initializer and Scenario Datasets #1224
rlundeen2
merged 23 commits into
Azure:main
from
rlundeen2:users/rlundeen/12_5_dataset_initializer
Dec 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
Dec 7, 2025
romanlutz
reviewed
Dec 7, 2025
romanlutz
reviewed
Dec 7, 2025
Contributor
|
I don't think we have integration tests covering this yet. We probably should... |
romanlutz
reviewed
Dec 7, 2025
romanlutz
reviewed
Dec 7, 2025
ValbuenaVC
reviewed
Dec 8, 2025
romanlutz
approved these changes
Dec 9, 2025
romanlutz
reviewed
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Three changes
This should and could be three PRs. But in my first change, I ended up having to make several other changes.
First Change: Scenario Dataset Initialization
This is the problem I set out to tackle. But if we break it up this needs to go in last.
required_datasetsfor scenarios to define required default dataset names.required_datasetsas part of the scenario inforequired_datasetsandDatasetProviderrequired_datasets, since it's a really easy way to get started.One problem: PyRItInitializer was synchronous, but we needed it to be async to use
DatasetProviderand load SeedPrompts into memoryIdeally this would have been a first PR. But it is a change I didn't know we needed until almost done with the first part (I originally wrapped with asyncio, but that was breaking notebooks and other eventloops).
required_datasetswithout asyncSecond problem: Many notebooks failing with target updates
And when running integration tests, I fixed times when the targets weren't working due to model not being defined.
PR Note: Again, this would be nice as a separate PR, but I was running this to fix my own changes (which essentially breaks every notebook due to initialize_pyrit updates) and stumbled upon this
PR Strategy
For the record, I'd say 80% of the code is just re-executing the jupyter notebooks because nearly every one had to be updated to use asynchronous
initialize_pyrit_async. And because all the output is new, that's a lot of files and LOC.This could be broken into three PRs, but it would go into reverse order and is a bit tough to pull apart. I'd prefer to keep as is because it's a lot less work. I recognize this adds difficult to the reviewer, but if it's too difficult to review, please raise this and I can break apart. But I think a lot of that breaking up would be manual
Tests and Docs
commit: 7a86bf4