fix(pxe): backport anchor header threading from #22679 to v4-next#22705
Draft
AztecBot wants to merge 4 commits intobackport-to-v4-next-stagingfrom
Draft
fix(pxe): backport anchor header threading from #22679 to v4-next#22705AztecBot wants to merge 4 commits intobackport-to-v4-next-stagingfrom
AztecBot wants to merge 4 commits intobackport-to-v4-next-stagingfrom
Conversation
BEGIN_COMMIT_OVERRIDE fix(pxe): cap event filter toBlock to last synced block (#22573) fix(pxe): round tx expiration timestamp to reduce precision (#22577) fix: eliminate anvil watcher warp race and false success logs (#22584) refactor: aztec new and init creating 2 crates (#20681) test: aztec new scaffold works (#20711) feat(cli): warning if contract crate has tests (#20723) feat(cli): auto-recompiling when aztec test is run (#20729) feat: aztec new supporting multiple contract crates (#21007) feat: asserts that aztec dep version matches cli (#21245) chore: backport aztec CLI improvements to v4-next (#22587) feat: check noir release has nargo binaries before releasing (#22551) chore: cache chainInfo in embeddedwallet (#22592) fix: wrap external getCapsule in transactionAsync (#22595) fix(pxe): throw clear error for invalid comparator in pick_notes (#22585) refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576) feat: infrastructure for testing `[new_contract_artfiacts, old_aztec_stack]` (#22593) chore: fix unnecessary and inconsistent side-effect counter increments (#22245) fix: update FaceID wallet redirects and strip anchors in redirect validation (#22505) docs: add getting started on testnet guide (#22366) docs: add getting started on testnet guide (backport #22366) (#22619) feat(aztec-nr): new BoundedVec emit private log APIs (#22064) END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE fix(docs): correct execution delay to 30 days and governance withdrawal to ~38 days (#22647) END_COMMIT_OVERRIDE
AztecBot
added
ci-draft
3 tasks
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the PXE-only portion of #22679 to
v4-next.The full fix in #22679 spans barretenberg world-state, the aztec-node and PXE; only the PXE refactor is portable to
v4-nextwithout dragging the C++ / world-state changes.What this changes
In
yarn-project/pxe/src/pxe.ts, capture the anchor header once perproveTx/simulateTx/profileTx(right afterblockStateSynchronizer.sync()) and thread it through to both#executePrivateand#prove, instead of re-readinganchorBlockStoreindependently inside each call.This is a defensive refactor — the anchor cannot drift today because both callees live inside the same job-queue slot — but it makes the invariant explicit and type-checked going forward.
What this does not include from #22679
WorldStateRevision::LATESTsentinel andis_historical()migration (barretenberg/cpp/src/barretenberg/world_state/*,avm_fuzzer/.../dbs.cpp)yarn-project/stdlib/src/world-state/world_state_revision.tsandyarn-project/world-state/src/native/native_world_state.tsAztecNodeService.getWorldStateinitial-header path change inyarn-project/aztec-node/src/aztec-node/server.ts(+ test)These are intentionally omitted per the request to backport only the PXE changes.
Notes
pxe.tsapplied cleanly at the exact line numbers — no conflict resolution needed.BlockHeaderwas already imported inpxe.tsonv4-next.#) methods are withinpxe.tsand are updated consistently.Original PR: #22679
ClaudeBox log: https://claudebox.work/s/6ab5b666456f5be7?run=1