fix: orchestrator enqueue yield#21286
Merged
PhilWindle merged 1 commit intomerge-train/spartanfrom Mar 13, 2026
Merged
Conversation
ludamad
reviewed
Mar 10, 2026
| // Workers yield between jobs via await, allowing I/O callbacks to process. | ||
| void this.deferredJobQueue.put(() => safeJob()); | ||
| void this.deferredJobQueue.put(async () => { | ||
| void safeJob(); |
Collaborator
There was a problem hiding this comment.
you can also do await safeJob() but I guess you'd have to fight the linter. (any await yields)
Contributor
Author
There was a problem hiding this comment.
Awaiting here would introduce a limit on how many proofs we have in flight at a time. We want to use fire-and-forget here and use callbacks to continue up the rollup
ludamad
approved these changes
Mar 10, 2026
PhilWindle
requested changes
Mar 11, 2026
| void this.deferredJobQueue.put(() => safeJob()); | ||
| void this.deferredJobQueue.put(async () => { | ||
| void safeJob(); | ||
| // we yield here to the macro task queue such to give Nodejs a chance to run other operatoins in between enqueues |
Collaborator
There was a problem hiding this comment.
I don't really understand this change. Doesn't this negate the purpose of having a queue and effectively take us back to setImmediate(() => void safeJob())?
PhilWindle
approved these changes
Mar 13, 2026
AztecBot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Fixes the orchestrator limiting the number of in-progress jobs, now it only limits the actual enqueuing operation and gives the event loop more room to breath. Either this PR must be backported or the previous PR #21247 must be removed the from the backport train.
Collaborator
|
✅ Successfully backported to backport-to-v4-staging #21477. |
AztecBot
added a commit
that referenced
this pull request
Mar 14, 2026
BEGIN_COMMIT_OVERRIDE fix: orchestrator enqueue yield (#21286) chore: default multiplier (#21482) chore: update yarn.lock (#21479) chore: backport #21231 feat!: improve L2ToL1MessageWitness API to v4 (#21463) feat(rpc): add package version to RPC response headers (#21526) feat(ethereum): check VK tree root and protocol contracts hash in rollup compatibility (#21537) feat: add public log filtering by tag (#21561) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the orchestrator limiting the number of in-progress jobs, now it only limits the actual enqueuing operation and gives the event loop more room to breath.
Either this PR must be backported or the previous PR #21247 must be removed the from the backport train.