Skip to content

docs: clarifying Noir fields vs struct fields in event metadata#21172

Merged
benesjan merged 1 commit intomerge-train/fairiesfrom
03-05-feat_final_touches_to_getdecodedpublicevents
Mar 6, 2026
Merged

docs: clarifying Noir fields vs struct fields in event metadata#21172
benesjan merged 1 commit intomerge-train/fairiesfrom
03-05-feat_final_touches_to_getdecodedpublicevents

Conversation

@benesjan
Copy link
Contributor

@benesjan benesjan commented Mar 5, 2026 •
edited
Loading

Just a smol docs PR tackling confusion between noir fields and struct members.

In a process of finishing #20332 (comment)

@benesjan Graphite App
Copy link
Contributor Author

benesjan commented Mar 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

benesjan
benesjan commented Mar 5, 2026
View reviewed changes
yarn-project/stdlib/src/logs/public_log.ts
public contractAddress: AztecAddress,
public fields: Fr[],
public readonly contractAddress: AztecAddress,
public readonly fields: Fr[],
Copy link
Contributor Author

@benesjan benesjan Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason for this to not be readonly

@benesjan benesjan marked this pull request as ready for review March 5, 2026 16:19
@benesjan benesjan changed the title feat: final touches to getDecodedPublicEvents docs: clarifying Noir fields vs struct fields in event metadata Mar 5, 2026
@benesjan benesjan requested a review from mverzilli March 5, 2026 16:46
@benesjan benesjan enabled auto-merge (squash) March 6, 2026 03:00
@benesjan benesjan merged commit 75724e6 into merge-train/fairies Mar 6, 2026
32 of 33 checks passed
@benesjan benesjan deleted the 03-05-feat_final_touches_to_getdecodedpublicevents branch March 6, 2026 03:53
@benesjan benesjan mentioned this pull request Mar 6, 2026
Closed
@AztecBot AztecBot mentioned this pull request Mar 6, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2026
@AztecBot
feat: merge-train/fairies (#21198)
03c2382 
BEGIN_COMMIT_OVERRIDE
docs: clarifying Noir fields vs struct fields in event metadata (#21172)
END_COMMIT_OVERRIDE
AztecBot pushed a commit that referenced this pull request Mar 6, 2026
@benesjan
docs: clarifying Noir fields vs struct fields in event metadata (#21172)
e8e7957 
Just a smol docs PR tackling confusion between noir fields and struct members.

In a process of finishing #20332 (comment)
@AztecBot AztecBot mentioned this pull request Mar 6, 2026
Merged
@AztecBot
Copy link
Collaborator

AztecBot commented Mar 6, 2026

✅ Successfully backported to backport-to-v4-staging #21187.

ludamad added a commit that referenced this pull request Mar 10, 2026
@AztecBot @ledwards2225
@PhilWindle @ludamad @mrzeszutko @spalladino @johnathan79717 @nventuro @alexghr @mverzilli @claude @benesjan @danielntmd @deffrian
chore: Accumulated backports to v4 (#21187)
4e7f820 
BEGIN_COMMIT_OVERRIDE
chore: chonk proof compression poc (#20645)
feat: Update L1 to L2 message APIs (#20913)
fix: adapt chonk proof compression for v4 Translator layout (#21067)
fix: omit bigint priceBumpPercentage from IPC config in testbench worker
(#21086)
feat: standby mode for prover broker (#21098)
fix(p2p): remove default block handler in favor of block handler
(#21105)
chore: prepare barretenberg-rs for crates.io publishing (#20496)
feat: reenable function selectors + additional validation in public
setup allowlist (backport #20909, #21122) (#21129)
chore: remove stale aes comments (#21133)
chore: remove auto-tag job (#21127)
feat: calldata length validation of public setup function allowlist
(#21139)
feat: run AVM NAPI simulations on dedicated threads instead of libuv
pool (#21138)
feat: Remove non-protocol contracts from public setup allowlist (#21154)
feat!: Expose offchain effects when simulating/sending txs (backport
#20563) (#21110)
chore: bump minor version (#21171)
chore: backport #21161 (tally slashing pruning improvements) to v4
(#21166)
chore: More updated Alpha configuration (backport #21155) (#21165)
fix(p2p): report most severe failure in runValidations (#21185)
feat: add ergonomic conversions for Noir's `Option<T>` (#21107)
docs: clarifying Noir fields vs struct fields in event metadata (#21172)
fix: bump lighthouse consensus client v7.1.0 -> v8.0.1 (#21170)
fix: update dependencies (#20997)
chore: New alpha-net environment (#20800) (#21202)
chore: code decuplication + refactor (public setup allowlist) (#21200)
feat: mask all ciphertext fields with Poseidon2-derived values (backport
#21009) (#21140)
chore: disable sponsored FPC in testnet (#21235)
feat!: exposing pub event pagination on wallet (#21197)
refactor(pxe): narrow tryGetPublicKeysAndPartialAddress return type
(backport #21208) (#21236)
feat: orchestrator enqueues via serial queue (#21247)
feat: rollup mana limit gas validation (#21219)
chore: deploy SPONSORED_FPC in test networks (#21254)
fix(sequencer): fix log when not enough txs (#21297)
END_COMMIT_OVERRIDE

---------

Co-authored-by: ledwards2225 <ledwards2225@users.noreply.github.com>
Co-authored-by: PhilWindle <PhilWindle@users.noreply.github.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: mrzeszutko <mrzeszutko@users.noreply.github.com>
Co-authored-by: spalladino <spalladino@users.noreply.github.com>
Co-authored-by: johnathan79717 <johnathan79717@users.noreply.github.com>
Co-authored-by: nventuro <nventuro@users.noreply.github.com>
Co-authored-by: alexghr <alexghr@users.noreply.github.com>
Co-authored-by: AztecBot <AztecBot@users.noreply.github.com>
Co-authored-by: Martin Verzilli <martin@aztec-labs.com>
Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: mverzilli <mverzilli@users.noreply.github.com>
Co-authored-by: benesjan <benesjan@users.noreply.github.com>
Co-authored-by: danielntmd <danielntmd@users.noreply.github.com>
Co-authored-by: deffrian <deffrian@users.noreply.github.com>
Co-authored-by: benesjan <janbenes1234@gmail.com>
@AztecBot AztecBot mentioned this pull request Mar 11, 2026
Merged
ludamad added a commit that referenced this pull request Mar 11, 2026
@ludamad
chore: Accumulated backports to v4 (#21355)
79156c4 
BEGIN_COMMIT_OVERRIDE
chore: chonk proof compression poc (#20645)
feat: Update L1 to L2 message APIs (#20913)
fix: adapt chonk proof compression for v4 Translator layout (#21067)
fix: omit bigint priceBumpPercentage from IPC config in testbench worker
(#21086)
feat: standby mode for prover broker (#21098)
fix(p2p): remove default block handler in favor of block handler
(#21105)
chore: prepare barretenberg-rs for crates.io publishing (#20496)
feat: reenable function selectors + additional validation in public
setup allowlist (backport #20909, #21122) (#21129)
chore: remove stale aes comments (#21133)
chore: remove auto-tag job (#21127)
feat: calldata length validation of public setup function allowlist
(#21139)
feat: run AVM NAPI simulations on dedicated threads instead of libuv
pool (#21138)
feat: Remove non-protocol contracts from public setup allowlist (#21154)
feat!: Expose offchain effects when simulating/sending txs (backport
#20563) (#21110)
chore: bump minor version (#21171)
chore: backport #21161 (tally slashing pruning improvements) to v4
(#21166)
chore: More updated Alpha configuration (backport #21155) (#21165)
fix(p2p): report most severe failure in runValidations (#21185)
feat: add ergonomic conversions for Noir's `Option<T>` (#21107)
docs: clarifying Noir fields vs struct fields in event metadata (#21172)
fix: bump lighthouse consensus client v7.1.0 -> v8.0.1 (#21170)
fix: update dependencies (#20997)
chore: New alpha-net environment (#20800) (#21202)
chore: code decuplication + refactor (public setup allowlist) (#21200)
feat: mask all ciphertext fields with Poseidon2-derived values (backport
#21009) (#21140)
chore: disable sponsored FPC in testnet (#21235)
feat!: exposing pub event pagination on wallet (#21197)
refactor(pxe): narrow tryGetPublicKeysAndPartialAddress return type
(backport #21208) (#21236)
feat: orchestrator enqueues via serial queue (#21247)
feat: rollup mana limit gas validation (#21219)
chore: deploy SPONSORED_FPC in test networks (#21254)
fix(sequencer): fix log when not enough txs (#21297)
fix: Simulate gas in n tps test. Set min txs per block to 1 (backport
#21312) (#21329)
fix(log): do not log validation error if unregistered handler (#21111)
fix(node): fix index misalignment in findLeavesIndexes (#21327)
fix: limit parallel blocks in prover to max AVM parallel simulations
(#21320)
fix: use native sha256 to speed up proving job id generation (#21292)
fix(validator): wait for l1 sync before processing block proposals
(#21336)
fix(txpool): cap priority fee with max fees when computing priority
(#21279)
chore: reduce severity of errors due to HA node not acquiring signature
(#21311)
fix: (A-643) add buffer to maxFeePerBlobGas for gas estimation and fix
bump loop truncation (#21323)
END_COMMIT_OVERRIDE
@AztecBot AztecBot mentioned this pull request Mar 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mverzilli mverzilli mverzilli approved these changes

Assignees

No one assigned

Labels

backport-to-v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benesjan @AztecBot @mverzilli