Conversation
Forward port of changes introduced in #21013
This adds the `aztec` namespace prefix to all oracles. We need this for noir-lang/noir#10105, so that we can get proper error messages on `nargo` that link to aztec docs. It also shortens the current prefixes: - `utility` → `utl` - `private` → `prv` - `avmOpcode` → `avm` - `txe` unchanged The prefixes only exist as the actual oracle name in the nr <> ts communication layer, they are not present in the nr code nor ts code. I actually removed the current prefixes from oracle handler fn (e.g. `utilityGetBlockNumber` becomes `getBlockNumber`) to reduce verbosity and repetitiveness, given that those functions already exist in interfaces that scope the oracles that correspond to that execution mode. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
nventuro
requested review from
LeilaWang,
dbanks12,
fcarreiro,
nventuro and
sirasistant
as code owners
…21102) ## Summary - Fixes contract class log DA gas metering in the PXE contract function simulator - Changed `+ 2` to `+ 1` for the additional fields per contract class log, matching the circuits (gas_meter.nr, tx_blob_data.nr, sponge_blob.nr) and the TS blob encoder which all use `+ 1` - Contract class logs only emit the contract address as an extra field (unlike private logs which also emit a length field), so the old `+ 2` was overcharging by 1 DA field (32 DA gas) per log Fixes F-377 ## Test plan - Existing tests pass — this is a gas metering correction, not a logic change - Contract class log blob encoding is unchanged; only the gas estimation in the PXE was wrong 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
What the title says.
What the title says.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: remove prefund env var in non local networks (#21095)
feat: aztec new supporting multiple contract crates (#21007)
feat!: Expose offchain effects when simulating/sending txs (#20563)
chore: exclude auto-generated dirs from VS Code search (#20881)
feat: improve oracle name prefixes (#21101)
fix(pxe): correct contract class log DA gas metering from +2 to +1 (#21102)
chore: remove stale aes comments (#21133)
chore: add warning on invalid recipients (#21134)
feat: mask ciphertext fields with Poseidon2-derived values (#21009)
END_COMMIT_OVERRIDE