Merged
Conversation
…g timetable" and "can call public function from different tx in same block as deployed" (#19252) These tests were skipped but no longer need to be. This uses priority fee to guarantee ordering of txs for the public functions test case.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
In the benchmarks dashboard, each tx will show sizes for all bytecodes
it interacts with. This will be another nested subgroup under each tx in
the dashboard.
The size is `packedBytecode.length` which is what is deployed and hashed
to produce bytecode commitment, which is in turn in the preimage of
classId.
Example in the markdown format for viewing in console:
## TX Label: AMM contract tests/AMM/add_liquidity/5
- Total duration: `281.073 ms`
- Total mana used: `366,757`
- Mana per second: `1,304,844`
- Total instructions executed: `4,636`
- Bytecode sizes:
- Token: `27,196 bytes`
- AMM: `10,027 bytes`
- Private insertions:
- Non-revertible: `4.197 ms`
- Revertible: `0.038 ms`
- Enqueued public calls:
- **Fn: Token._increase_public_balance**
- Duration: `24.537 ms`
- Mana used: `47,531`
- Mana per second: `1,937,098`
- Instructions executed: `513`
- **Fn: Token._increase_public_balance**
- Duration: `21.584 ms`
- Mana used: `47,531`
- Mana per second: `2,202,119`
- Instructions executed: `513`
- **Fn: AMM._add_liquidity**
- Duration: `170.29 ms`
- Mana used: `271,695`
- Mana per second: `1,595,484`
- Instructions executed: `3,610`
And for avm test contract:
## TX Label: AvmTest contract tests/AvmTest/bulk_testing/0
- Total duration: `1,023.971 ms`
- Total mana used: `1,913,343`
- Mana per second: `1,868,552`
- Total instructions executed: `72,382`
- Bytecode sizes:
- AvmTest: `54,963 bytes`
- Private insertions:
- Non-revertible: `15.939 ms`
- Revertible: `6.066 ms`
- Enqueued public calls:
...
dbanks12
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
Prove and verify with check circuit as well in the fuzzing runs for completeness
Any commits made after this event will not be merged.
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
test: fix and unskip block building tests "processes txs until hitting timetable" and "can call public function from different tx in same block as deployed" (#19252)
feat: add public bytecode sizes to benchmarks dashboard (#20704)
feat(avm): enable proving during fuzzing (#20523)
END_COMMIT_OVERRIDE