fix(operator): enhance connection handling in QueryHandler#20
Merged
Conversation
… both callback and promise-based MySQL connection pools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… both callback and promise-based MySQL connection pools
Note
Updates
beginTransactionto detect mysql2 pool type and acquire a connection appropriately, converting to promise-based when needed.src/operator.js):QueryHandler.beginTransaction):PoolvsPromisePool) viapromise()presence.getConnectionin a Promise and converts connection withconn.promise().getConnection().commit/rollback.Written by Cursor Bugbot for commit 00ac303. This will update automatically on new commits. Configure here.