Conversation
There was a problem hiding this comment.
Pull request overview
This PR marks four public methods in QueryableExtensions.cs as obsolete using the [Obsolete] attribute, directing users to the newer GetQuery/GetQueryAsync methods instead. It also bumps the minimum version of AutoMapper.Extensions.ExpressionMapping from 10.0.0 to 10.1.0.
Changes:
- Added
[Obsolete]attributes to twoGet/GetAsyncoverloads that acceptODataQueryOptions, pointing users toGetQuery/GetQueryAsync. - Added
[Obsolete]attributes to twoGet/GetAsyncoverloads that accept raw filter/query expressions, noting they were meant for internal use. - Bumped the minimum version of
AutoMapper.Extensions.ExpressionMappingfrom10.0.0to10.1.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AutoMapper.AspNetCore.OData.EFCore/QueryableExtensions.cs | Added [Obsolete] attributes to four public extension methods to guide consumers toward preferred alternatives. |
| AutoMapper.AspNetCore.OData.EFCore/AutoMapper.AspNetCore.OData.EFCore.csproj | Bumped AutoMapper.Extensions.ExpressionMapping minimum version from 10.0.0 to 10.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AutoMapper.AspNetCore.OData.EFCore/AutoMapper.AspNetCore.OData.EFCore.csproj
Show resolved
Hide resolved
BlaiseD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking obsolete methods. Bumps the minimum version of AutoMapper.Extensions.ExpressionMapping to10.1.0.