Add a Download button to the output dialogs#21
Open
namedgraph wants to merge 1 commit into
Open
Conversation
Source and Extract RDF now offer the shown text as a file download (content.xhtml / content.rdf): local:show-output takes optional filename/media-type params and reveals the button only when a caller passes them - the lint modal doesn't, so it keeps the plain view. The download is a client-side Blob clicked through an ephemeral object-URL anchor, so it works on any static hosting (gh-pages included). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source and Extract RDF now offer their output as a file download —
content.xhtml(application/xhtml+xml) andcontent.rdf(application/rdf+xml).local:show-outputgains optionalfilename/media-typeparams; the Download button appears only when a caller passes them (the lint issues modal doesn't, so it stays view-only).Blob, clicked through an ephemeral object-URL anchor — no server endpoint, so it works on static hosting including GitHub Pages.editor.mjscaptures both downloads via Playwright's download event and asserts filename + byte-identical content against the dialog text;features.mjsasserts the lint modal hides the button. All 15 suites pass.Stacked on #20 (
feature/canonical-xml-c14n) — the view-source call site is shared.🤖 Generated with Claude Code