fix: implement CodeRabbit findings (#3364)#3371

Merged

KATO-Hiro merged 47 commits into

Apr 9, 2026

Commits on Apr 6, 2026

docs: Add plan and review for PR #3316 post-merge fixes

KATO-Hiro
and
claude
committed
test: migrate process.env manual stubs to vi.stubEnv in atcoder_verification tests
KATO-Hiro
committed
test: add unit tests for getUser, getUserById, and deleteUser
KATO-Hiro
committed
refactor: extract MIN_VOTES_FOR_STATISTICS to client-safe constant and remove hardcoded '3' in votes page
KATO-Hiro
committed
docs: update plan - use internal_clients/vote_grade.ts instead of services/vote_api.ts (non-service layer clarification)
KATO-Hiro
committed
refactor: add return value to upsertVoteGradeTables and use it in vote_actions
KATO-Hiro
committed
fix: handle RecordNotFound error in setTaskGrade action for vote_management
KATO-Hiro
committed
feat: add loading state to SubmissionButton via FormWrapper context (prevent double-submit)
KATO-Hiro
committed
feat: add button gap and replace custom clipboard with Flowbite Clipboard in AtCoderVerificationForm
KATO-Hiro
committed
fix: ensure isSubmitting is reset even when form update throws exception
KATO-Hiro
committed
docs: fix comment wording and remove redundant type assertion
KATO-Hiro
committed
feat: create vote_grade internal client with fetchMyVote, submitVote, fetchMedianVote
KATO-Hiro
committed
refactor: use vote_grade.ts in VotableGrade and add AbortController for rapid-click protection
KATO-Hiro
committed
fix: update E2E test selectors and add initial state check for votes page
KATO-Hiro
committed
feat: add CHECK constraints for vote grade models (count >= 0, grade != PENDING)
KATO-Hiro
committed
docs: add new coding rules derived from PR #3316 review (SSR, FK, auth, env stubs)
KATO-Hiro
committed
fix: address CodeRabbit findings - remove misleading test and fix FormData inconsistency
KATO-Hiro
committed
Merge branch 'staging' of github.com:AtCoder-NoviSteps/AtCoderNoviSteps into #3364
KATO-Hiro
committed

Commits on Apr 8, 2026