-
-
Notifications
You must be signed in to change notification settings - Fork 10
build(deps-dev): Bump eslint from 9.39.2 to 10.1.0 (#3304) #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ab1ab5e
chore: Upgrade eslint 9→10 and @eslint/js 9→10, add upgrade plan
KATO-Hiro fb94564
docs: Remove eslint-v10-upgrade plan (no-op upgrade, no separate plan…
KATO-Hiro 47dfb87
docs: Add dep-upgrade skill and update claude-code guide
KATO-Hiro 4e8bf26
docs: Fix minor wording in dep-upgrade skill and claude-code guide
KATO-Hiro bf3097e
docs: Update dep-upgrade skill instructions
KATO-Hiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| name: dep-upgrade | ||
| description: Analyze a major version dependency upgrade: summarize breaking changes, assess project impact, and propose new features to adopt. Outputs a plan.md and executes the upgrade. | ||
| disable-model-invocation: true | ||
| argument-hint: '<package-name> <old-major> <new-major>' | ||
| --- | ||
|
|
||
| Analyze and execute the major version upgrade for: $ARGUMENTS | ||
|
|
||
| 1. **Analyze** — fetch the official migration guide via WebFetch; apply the checklist in [instructions.md](instructions.md) | ||
| 2. **Generate plan** — create `docs/dev-notes/YYYY-MM-DD/{package}-upgrade/plan.md` with breaking changes, impact, and new features; **stop and ask for confirmation** | ||
| 3. **Execute** — update `package.json`, run `pnpm install && pnpm lint && pnpm check && pnpm test:unit`; update the plan checklist when done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # Dependency Major Upgrade Checklist | ||
|
|
||
| ## 1. Breaking Changes Analysis | ||
|
|
||
| Fetch the official migration guide via WebFetch. For each breaking change, grep `src/`, config files, | ||
| and `package.json` to determine applicability. Produce two tables: | ||
|
|
||
| **問題なし(対応不要)** | ||
|
|
||
| | Confirmed Item | Rationale | | ||
| | -------------- | --------- | | ||
| | ... | ... | | ||
|
|
||
| **要対応** | ||
|
|
||
| | Item | Content | Risk | | ||
| | ---- | ------- | ------------------- | | ||
| | ... | ... | High / Medium / Low | | ||
|
|
||
| Key areas to check: | ||
|
|
||
| - Runtime requirements (`engines.node` in `package.json`) | ||
| - Config file format changes (flat config vs legacy, etc.) | ||
| - Deprecated/removed APIs used in `src/` | ||
| - Directive comments that become errors in the new version (e.g., `/* eslint-env */` in ESLint v10) | ||
|
|
||
| ## 2. Companion Package Check | ||
|
|
||
| Some packages must be upgraded together in the same commit to avoid version mismatch. | ||
| Check `package.json` for known companion pairs: | ||
|
|
||
| - `@sveltejs/kit` + `@sveltejs/vite-plugin-svelte` | ||
| - `eslint` + `@eslint/js` | ||
|
|
||
| Also verify peer dependency compatibility (`"eslint": "^8 || ^9 || ^10"` style) for all | ||
| related packages already installed. | ||
|
|
||
| If companion packages are found, include them in the upgrade scope. | ||
|
|
||
| ## 3. New Features to Adopt | ||
|
|
||
| List features unlocked by the new major version: | ||
|
|
||
| | Feature | Description | Recommendation | | ||
| | ------- | ----------- | ------------------- | | ||
| | ... | ... | High / Medium / Low | | ||
|
|
||
| ## 4. plan.md Structure | ||
|
|
||
| Write `docs/dev-notes/YYYY-MM-DD/{package}-upgrade/plan.md` in Japanese: | ||
|
|
||
| - **概要**: Which Dependabot PR / bump triggered this; summary of scope | ||
| - **破壊的変更の影響調査結果**: Tables from sections 1–2 above | ||
| - **設計方針**: How to handle action-required items; companion package strategy | ||
| - **却下した代替案**: Alternatives considered (e.g., upgrading only one of a companion pair) | ||
| - **便利な新機能(採用検討)**: Table from section 3 | ||
| - **実装フェーズ**: Phased `- [ ]` checklist (lowest risk → highest risk) | ||
| - **検証手順**: The exact commands to run | ||
|
|
||
| ## 5. Verification Commands | ||
|
|
||
| ```bash | ||
| pnpm install | ||
| pnpm lint | ||
| pnpm check | ||
| pnpm test:unit | ||
| ``` | ||
|
|
||
| > **`pnpm check` tip:** If type errors appear and you have uncommitted changes, run | ||
| > `git stash && pnpm check 2>&1 | tail -5` to confirm whether errors are pre-existing. | ||
| > Restore with `git stash pop`. If there is nothing to stash, skip this check — without | ||
| > a baseline to compare against, it gives no useful signal. | ||
|
|
||
| Update the plan.md `- [ ]` checklist and add a verification results table when done. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.