Skip to content

fix: Address lint errors after svelte-check and eslint pass #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KATO-Hiro merged 2 commits into from
Mar 23, 2026
Merged

fix: Address lint errors after svelte-check and eslint pass #3301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2690d
fix: Address lint errors after svelte-check and eslint pass
KATO-Hiro Mar 23, 2026
cce098d
fix: Preserve hash and page state in KanbanBoard replaceState call
KATO-Hiro Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/tasks/components/contest-table/TaskTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
let contestTableMaps = $derived(prepareContestTablesMap(providers));

function prepareContestTablesMap(providers: ContestTableProvider[]): Map<string, ProviderData> {
const map = new Map<string, ProviderData>();
const map = new SvelteMap<string, ProviderData>();

for (const provider of providers) {
const abbreviationName = provider.getMetadata().abbreviationName;
Expand Down Expand Up @@ -162,7 +162,7 @@
});

let taskIndicesMap = $derived.by(() => {
const indices = new Map<ContestTaskPairKey, number>();
const indices = new SvelteMap<ContestTaskPairKey, number>();

taskResults.forEach((task, index) => {
const key = createContestTaskPairKey(task.contest_id, task.task_id);
Expand Down
1 change: 1 addition & 0 deletions src/lib/components/AuthForm.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@

<div class="text-sm font-medium text-gray-500 dark:text-gray-300">
{confirmationMessage}
<!-- eslint-disable-next-line svelte/no-navigation-without-resolve -->
<a href={alternativeHref} class="text-primary-700 hover:underline dark:text-primary-500">
Comment thread
KATO-Hiro marked this conversation as resolved.
{alternativePageName}
</a>
Expand Down
4 changes: 3 additions & 1 deletion src/routes/(admin)/workbooks/order/_components/KanbanBoard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script lang="ts">
import { page } from '$app/stores';
import { replaceState } from '$app/navigation';
import { resolve } from '$app/paths';
import { untrack } from 'svelte';

import { Toast } from 'flowbite-svelte';
Expand Down Expand Up @@ -59,7 +60,8 @@
selectedSolutionCategories,
selectedGrades,
);
replaceState(updatedUrl, {});
// @ts-expect-error svelte-check TS2554: AppTypes declaration merging causes RouteId to resolve as string, requiring params. Runtime behavior is correct.
replaceState(resolve(updatedUrl.pathname) + updatedUrl.search + updatedUrl.hash, $page.state);
}

let allItems = $state<Record<string, KanbanColumns>>(
Expand Down
Loading