Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds token-transfer ABI support and convenience encoding/building helpers to generate ERC-20 transfer calldata and submit it as an EvmCall transaction.
Changes:
- Add
TOKENcontract ABI type +Abi.Token.jsonartifact and register it inAbiBase. - Introduce
TransactionEncoderutility for encoding common contract call payloads, including tokentransfer. - Add
TokenTransferBuilder+ corresponding unit tests for payload construction and signing/verifying.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/Utils/TransactionEncoderTest.php | Adds unit tests for encoded payload outputs (incl. token transfer) and invalid-address rejection. |
| tests/Unit/Transactions/Builder/TokenTransferBuilderTest.php | Adds tests validating token transfer builder calldata and signature verification. |
| src/Utils/TransactionEncoder.php | New utility for ABI-encoding calldata for multipayment, token transfer, usernames, and consensus calls. |
| src/Utils/AbiBase.php | Registers ContractAbiType::TOKEN -> Abi.Token.json path. |
| src/Utils/Abi/json/Abi.Token.json | Adds token ABI artifact containing transfer (and related) function definitions. |
| src/Transactions/Builder/TokenTransferBuilder.php | Adds builder to construct EvmCall token transfer transactions using ABI encoding. |
| src/Enums/ContractAbiType.php | Adds TOKEN enum case. |
| src/Enums/AbiFunction.php | Adds TRANSFER function enum and maps it to EvmCall. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86e00vrhr
https://app.clickup.com/t/86e00vrmd
https://app.clickup.com/t/86e00vrn9
Checklist