Skip to content

Antalya 26.3 - Use regression runners for smaller checks jobs [CI Cost Reduction] #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strtgbb wants to merge 1 commit into
base: antalya-26.3
Choose a base branch
from
Open

Antalya 26.3 - Use regression runners for smaller checks jobs [CI Cost Reduction] #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 59 additions & 59 deletions .github/workflows/master.yml
View file
Open in desktop

Large diffs are not rendered by default.

106 changes: 53 additions & 53 deletions .github/workflows/pull_request.yml
View file
Open in desktop

Large diffs are not rendered by default.

92 changes: 46 additions & 46 deletions .github/workflows/pull_request_community.yml
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions .github/workflows/release_builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ jobs:
for line in sys.stdin: sys.stdout.write(prefix() + " " + line); sys.stdout.flush()' | tee ./ci/tmp/job.log

install_packages_amd_release:
runs-on: [self-hosted, altinity-on-demand, altinity-func-tester]
runs-on: [self-hosted, altinity-on-demand, altinity-regression-tester]
needs: [build_amd_release, config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
if: ${{ !cancelled() && !contains(needs.*.outputs.pipeline_status, 'failure') && !contains(needs.*.outputs.pipeline_status, 'undefined') && !contains(fromJson(needs.config_workflow.outputs.data).workflow_config.cache_success_base64, 'SW5zdGFsbCBwYWNrYWdlcyAoYW1kX3JlbGVhc2Up') }}
name: "Install packages (amd_release)"
Expand Down Expand Up @@ -936,7 +936,7 @@ jobs:
for line in sys.stdin: sys.stdout.write(prefix() + " " + line); sys.stdout.flush()' | tee ./ci/tmp/job.log

install_packages_arm_release:
runs-on: [self-hosted, altinity-on-demand, altinity-func-tester-aarch64]
runs-on: [self-hosted, altinity-on-demand, altinity-regression-tester-aarch64]
needs: [build_arm_release, config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
if: ${{ !cancelled() && !contains(needs.*.outputs.pipeline_status, 'failure') && !contains(needs.*.outputs.pipeline_status, 'undefined') && !contains(fromJson(needs.config_workflow.outputs.data).workflow_config.cache_success_base64, 'SW5zdGFsbCBwYWNrYWdlcyAoYXJtX3JlbGVhc2Up') }}
name: "Install packages (arm_release)"
Expand Down Expand Up @@ -1037,7 +1037,7 @@ jobs:
for line in sys.stdin: sys.stdout.write(prefix() + " " + line); sys.stdout.flush()' | tee ./ci/tmp/job.log

stateless_tests_arm_binary_sequential:
runs-on: [self-hosted, altinity-on-demand, altinity-func-tester-aarch64]
runs-on: [self-hosted, altinity-on-demand, altinity-regression-tester-aarch64]
needs: [build_arm_binary, config_workflow, dockers_build_amd, dockers_build_arm, dockers_build_multiplatform_manifest]
if: ${{ !cancelled() && !contains(needs.*.outputs.pipeline_status, 'failure') && !contains(needs.*.outputs.pipeline_status, 'undefined') && !contains(fromJson(needs.config_workflow.outputs.data).workflow_config.cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhcm1fYmluYXJ5LCBzZXF1ZW50aWFsKQ==') }}
name: "Stateless tests (arm_binary, sequential)"
Expand Down
21 changes: 15 additions & 6 deletions ci/defs/defs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,32 @@ class RunnerLabels:
]
AMD_LARGE = ["self-hosted", "altinity-on-demand", "altinity-func-tester"]
ARM_LARGE = ["self-hosted", "altinity-on-demand", "altinity-func-tester-aarch64"]
AMD_MEDIUM = ["self-hosted", "altinity-on-demand", "altinity-func-tester"]
AMD_MEDIUM = ["self-hosted", "altinity-on-demand", "altinity-regression-tester"]
ARM_MEDIUM = ["self-hosted", "altinity-on-demand", "altinity-func-tester-aarch64"]
AMD_MEDIUM_CPU = ["self-hosted", "altinity-on-demand", "altinity-func-tester"]
AMD_MEDIUM_CPU = ["self-hosted", "altinity-on-demand", "altinity-regression-tester"]
ARM_MEDIUM_CPU = [
"self-hosted",
"altinity-on-demand",
"altinity-func-tester-aarch64",
]
AMD_MEDIUM_MEM = ["self-hosted", "altinity-on-demand", "altinity-func-tester"]
AMD_MEDIUM_MEM = ["self-hosted", "altinity-on-demand", "altinity-regression-tester"]
ARM_MEDIUM_MEM = [
"self-hosted",
"altinity-on-demand",
"altinity-func-tester-aarch64",
]
AMD_SMALL = ["self-hosted", "altinity-on-demand", "altinity-style-checker"]
ARM_SMALL = ["self-hosted", "altinity-on-demand", "altinity-style-checker-aarch64"]
AMD_SMALL_MEM = ["self-hosted", "altinity-on-demand", "altinity-style-checker"]
AMD_SMALL = ["self-hosted", "altinity-on-demand", "altinity-regression-tester"]
ARM_SMALL = [
"self-hosted",
"altinity-on-demand",
"altinity-regression-tester-aarch64",
]
AMD_SMALL_MEM = ["self-hosted", "altinity-on-demand", "altinity-regression-tester"]
ARM_SMALL_MEM = [
"self-hosted",
"altinity-on-demand",
"altinity-regression-tester-aarch64",
]
MACOS_ARM_SMALL = ["self-hosted", "arm_macos_small"]
MACOS_AMD_SMALL = ["self-hosted", "amd_macos_m1"]
STYLE_CHECK_AMD = ["self-hosted", "altinity-on-demand", "altinity-style-checker"]
Expand Down
46 changes: 23 additions & 23 deletions ci/defs/job_configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ class JobConfigs:
).parametrize(
Job.ParamSet(
parameter="amd_release",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL,
requires=[
ArtifactNames.DEB_AMD_RELEASE,
ArtifactNames.CH_AMD_RELEASE,
Expand All @@ -453,7 +453,7 @@ class JobConfigs:
),
Job.ParamSet(
parameter="arm_release",
runs_on=RunnerLabels.FUNC_TESTER_ARM,
runs_on=RunnerLabels.ARM_SMALL,
requires=[
ArtifactNames.DEB_ARM_RELEASE,
ArtifactNames.CH_ARM_RELEASE,
Expand All @@ -476,7 +476,7 @@ class JobConfigs:
).parametrize(
Job.ParamSet(
parameter="amd_release",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL,
requires=[
ArtifactNames.DEB_AMD_RELEASE,
ArtifactNames.RPM_AMD_RELEASE,
Expand All @@ -486,7 +486,7 @@ class JobConfigs:
),
Job.ParamSet(
parameter="arm_release",
runs_on=RunnerLabels.FUNC_TESTER_ARM,
runs_on=RunnerLabels.ARM_SMALL,
requires=[
ArtifactNames.DEB_ARM_RELEASE,
ArtifactNames.RPM_ARM_RELEASE,
Expand Down Expand Up @@ -576,7 +576,7 @@ class JobConfigs:
],
Job.ParamSet(
parameter="amd_asan, db disk, distributed plan, sequential",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL_MEM,
requires=[ArtifactNames.CH_AMD_ASAN_GH],
),
# Job.ParamSet( # NOTE (strtgbb): llvm cov jobs not configured yet. Determine if useful first.
Expand Down Expand Up @@ -617,18 +617,18 @@ class JobConfigs:
# ),
Job.ParamSet(
parameter="amd_debug, parallel",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_MEDIUM_CPU,
requires=[ArtifactNames.CH_AMD_DEBUG_GH],
),
Job.ParamSet(
parameter="amd_debug, sequential",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL,
requires=[ArtifactNames.CH_AMD_DEBUG_GH],
),
*[
Job.ParamSet(
parameter=f"amd_tsan, parallel, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_LARGE,
requires=[ArtifactNames.CH_AMD_TSAN_GH],
)
for total_batches in (2,)
Expand All @@ -637,7 +637,7 @@ class JobConfigs:
*[
Job.ParamSet(
parameter=f"amd_tsan, sequential, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL,
requires=[ArtifactNames.CH_AMD_TSAN_GH],
)
for total_batches in (2,)
Expand All @@ -646,7 +646,7 @@ class JobConfigs:
*[
Job.ParamSet(
parameter=f"amd_msan, WasmEdge, parallel, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_LARGE,
requires=[ArtifactNames.CH_AMD_MSAN_GH],
)
for total_batches in (4,)
Expand All @@ -655,36 +655,36 @@ class JobConfigs:
*[
Job.ParamSet(
parameter=f"amd_msan, WasmEdge, sequential, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL_MEM,
requires=[ArtifactNames.CH_AMD_MSAN_GH],
)
for total_batches in (2,)
for batch in range(1, total_batches + 1)
],
Job.ParamSet(
parameter="amd_ubsan, parallel",
runs_on=RunnerLabels.FUNC_TESTER_AMD, # it runs much faster than many job, no need larger machine
runs_on=RunnerLabels.AMD_SMALL_MEM, # it runs much faster than many job, no need larger machine
requires=[ArtifactNames.CH_AMD_UBSAN_GH],
),
Job.ParamSet(
parameter="amd_ubsan, sequential",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL_MEM,
requires=[ArtifactNames.CH_AMD_UBSAN_GH],
),
Job.ParamSet(
parameter="amd_debug, distributed plan, s3 storage, parallel",
runs_on=RunnerLabels.FUNC_TESTER_AMD, # large machine - no boost, why?
runs_on=RunnerLabels.AMD_MEDIUM, # large machine - no boost, why?
requires=[ArtifactNames.CH_AMD_DEBUG_GH],
),
Job.ParamSet(
parameter="amd_debug, distributed plan, s3 storage, sequential",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL,
requires=[ArtifactNames.CH_AMD_DEBUG_GH],
),
*[
Job.ParamSet(
parameter=f"amd_tsan, s3 storage, parallel, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_MEDIUM,
requires=[ArtifactNames.CH_AMD_TSAN_GH],
)
for total_batches in (2,)
Expand All @@ -693,28 +693,28 @@ class JobConfigs:
*[
Job.ParamSet(
parameter=f"amd_tsan, s3 storage, sequential, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL_MEM,
requires=[ArtifactNames.CH_AMD_TSAN_GH],
)
for total_batches in (2,)
for batch in range(1, total_batches + 1)
],
Job.ParamSet(
parameter="arm_binary, parallel",
runs_on=RunnerLabels.FUNC_TESTER_ARM,
runs_on=RunnerLabels.ARM_MEDIUM_CPU,
requires=[ArtifactNames.CH_ARM_BINARY_GH],
),
Job.ParamSet(
parameter="arm_binary, sequential",
runs_on=RunnerLabels.FUNC_TESTER_ARM,
runs_on=RunnerLabels.ARM_SMALL,
requires=[ArtifactNames.CH_ARM_BINARY_GH],
),
)
functional_tests_jobs_coverage = common_ft_job_config.parametrize(
*[
Job.ParamSet(
parameter=f"{BuildTypes.AMD_COVERAGE}, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_AMD,
runs_on=RunnerLabels.AMD_SMALL,
requires=[ArtifactNames.CH_COV_BIN],
)
for total_batches in (8,)
Expand All @@ -727,7 +727,7 @@ class JobConfigs:
*[
Job.ParamSet(
parameter=f"arm_asan, azure, parallel, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_ARM,
runs_on=RunnerLabels.ARM_MEDIUM,
requires=[ArtifactNames.CH_ARM_ASAN_GH],
)
for total_batches in (4,)
Expand All @@ -736,7 +736,7 @@ class JobConfigs:
*[
Job.ParamSet(
parameter=f"arm_asan, azure, sequential, {batch}/{total_batches}",
runs_on=RunnerLabels.FUNC_TESTER_ARM,
runs_on=RunnerLabels.ARM_SMALL_MEM,
requires=[ArtifactNames.CH_ARM_ASAN_GH],
timeout=3600 * 4,
)
Expand All @@ -746,7 +746,7 @@ class JobConfigs:
)
bugfix_validation_it_job = (
common_integration_test_job_config.set_name(JobNames.BUGFIX_VALIDATE_IT)
.set_runs_on(RunnerLabels.FUNC_TESTER_AMD)
.set_runs_on(RunnerLabels.AMD_SMALL_MEM)
.set_command(
"python3 ./ci/jobs/integration_test_job.py --options BugfixValidation"
)
Expand Down
Loading