Skip to content

Antalya 25.8 - Fix CrashWriter to check empty endpoint before sending crash report #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 1 commit into from
Mar 11, 2026
Merged

Antalya 25.8 - Fix CrashWriter to check empty endpoint before sending crash report #1508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Daemon/CrashWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ std::unique_ptr<CrashWriter> CrashWriter::instance;

void CrashWriter::initialize(Poco::Util::LayeredConfiguration & config)
{
if (config.getBool("send_crash_reports.enabled", false))
instance.reset(new CrashWriter(config));
instance.reset(new CrashWriter(config));
}

bool CrashWriter::initialized()
Expand Down Expand Up @@ -70,6 +69,12 @@ void CrashWriter::sendError(Type type, int sig_or_error, std::string_view error_
return;
}

if (endpoint.empty())
{
LOG_DEBUG(logger, "Not sending crash report (crash reporting is disabled)");
return;
}

try
{
LOG_INFO(logger, "Sending crash report");
Expand Down
Loading