__aliasMarker refactoring to cover complex cases with ALIASes#1463
Open
filimonov wants to merge 2 commits intoantalya-26.1from
Open
__aliasMarker refactoring to cover complex cases with ALIASes#1463filimonov wants to merge 2 commits intoantalya-26.1from
filimonov wants to merge 2 commits intoantalya-26.1from
Conversation
This was referenced Mar 10, 2026
Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
e55a22a to
c8bc98a
Compare
Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
685639d to
5e3b051
Compare
Member
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Rework __aliasMarker to cover complex cases of aliases in distributed / hybrid scenarios.
Documentation entry for user-facing changes
Rework __aliasMarker to make the injection happen in 2 phases. Initially the inject a function call with the column reference (which can be renamed / realiased etc), and later materialize / finalize it to string before sending down to shard.
See also comment in identity.h
Closes #1424
Closes #1335